Merge ~liushuyu-011/ubuntu/+source/rust-zram-generator:ubuntu/devel into ubuntu/+source/rust-zram-generator:ubuntu/devel

Proposed by Zixing Liu
Status: Needs review
Proposed branch: ~liushuyu-011/ubuntu/+source/rust-zram-generator:ubuntu/devel
Merge into: ubuntu/+source/rust-zram-generator:ubuntu/devel
Diff against target: 24 lines (+12/-0)
2 files modified
debian/patches/series (+1/-0)
debian/patches/use-thin-lto.patch (+11/-0)
Reviewer Review Type Date Requested Status
Zixing Liu (community) Disapprove
Sebastien Bacher (community) Needs Fixing
git-ubuntu import Pending
Review via email: mp+440544@code.launchpad.net

Description of the change

This fixes the debug information saving using the ThinLTO instead of the full LTO.
See https://github.com/rust-lang/rust/pull/89041 for the background information.

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thank you for your contribution. It seems another change was made after that one was proposed which landed as https://launchpad.net/ubuntu/+source/rust-zram-generator/1.1.2-2ubuntu1. Is the current change still desirable? If so could you add a changelog entry describing the change and perhaps forward to Debian so we could keep the package synced?

review: Needs Fixing
Revision history for this message
Zixing Liu (liushuyu-011) wrote :

> https://launchpad.net/ubuntu/+source/rust-zram-generator/1.1.2-2ubuntu1

It looks like this one used a more brute-force way to fix the build (by disabling the debug information).

I think I will reject this merge proposal myself.

review: Disapprove

Unmerged commits

db065b1... by Zixing Liu

d/patches: use thinLTO to avoid LLVM generating bad debuginfo

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/patches/series b/debian/patches/series
2index 75abb7f..399b108 100644
3--- a/debian/patches/series
4+++ b/debian/patches/series
5@@ -1 +1,2 @@
6 relax-dep.diff
7+use-thin-lto.patch
8diff --git a/debian/patches/use-thin-lto.patch b/debian/patches/use-thin-lto.patch
9new file mode 100644
10index 0000000..c8eefdb
11--- /dev/null
12+++ b/debian/patches/use-thin-lto.patch
13@@ -0,0 +1,11 @@
14+--- a/Cargo.toml 2023-04-04 16:28:38.868577487 -0600
15++++ b/Cargo.toml 2023-04-04 16:28:47.176709209 -0600
16+@@ -20,7 +20,7 @@
17+ license = "MIT"
18+ [profile.release]
19+ opt-level = "z"
20+-lto = true
21++lto = "thin"
22+ codegen-units = 1
23+ panic = "abort"
24+ [dependencies.anyhow]

Subscribers

People subscribed via source and target branches

to all changes: