Merge ~liushuyu-011/ubuntu/+source/openboard:ubuntu/oracular-devel into ubuntu/+source/openboard:ubuntu/devel

Proposed by Zixing Liu
Status: Merged
Merge reported by: Zixing Liu
Merged at revision: 33c970015702eebec80024ba743a6041f71bcecb
Proposed branch: ~liushuyu-011/ubuntu/+source/openboard:ubuntu/oracular-devel
Merge into: ubuntu/+source/openboard:ubuntu/devel
Diff against target: 63 lines (+41/-0)
3 files modified
debian/changelog (+13/-0)
debian/patches/2011_ffmpeg-7.patch (+27/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Vladimir Petko (community) Approve
Review via email: mp+473395@code.launchpad.net

Description of the change

This merge proposal adds a patch to fix FTBFS issue with FFmpeg 7

To post a comment you must log in.
Revision history for this message
Vladimir Petko (vpa1977) wrote :

- Please add the patch header as it is not clear where the patch is coming from. Note, please forward it upstream if it is ours.
- Please add ftbfs bug and reference it in the changelog/patch

review: Needs Fixing
Revision history for this message
Zixing Liu (liushuyu-011) wrote :

> - Please add the patch header as it is not clear where the patch is coming from. Note, please forward it upstream if it is ours.

I will mark it as "not-needed" as our OpenBoard is a severely outdated version.

Revision history for this message
Zixing Liu (liushuyu-011) wrote :
Revision history for this message
Vladimir Petko (vpa1977) :
review: Approve
Revision history for this message
Vladimir Petko (vpa1977) wrote :

Note: fixed bug-debian reference to https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1080949 on upload

Revision history for this message
Vladimir Petko (vpa1977) wrote (last edit ):

Could not upload, there is already ubuntu2 sitting in the queue.

0a6e7b9... by Gianfranco Costamagna

changelog

Revision history for this message
Vladimir Petko (vpa1977) wrote :

Uploaded, thank you!!!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index ace4dd3..121d43c 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,16 @@
6+openboard (1.6.4+dfsg-1ubuntu3) oracular; urgency=medium
7+
8+ * d/p/2011_ffmpeg-7.patch: add a patch to fix FTBFS with ffmpeg 7
9+ (LP: #2079134).
10+
11+ -- Zixing Liu <zixing.liu@canonical.com> Tue, 17 Sep 2024 15:12:19 -0600
12+
13+openboard (1.6.4+dfsg-1ubuntu2) oracular; urgency=medium
14+
15+ * Rebuild against new libavcodec61.
16+
17+ -- Gianfranco Costamagna <locutusofborg@debian.org> Wed, 31 Jul 2024 17:19:45 +0200
18+
19 openboard (1.6.4+dfsg-1ubuntu1) oracular; urgency=medium
20
21 * Fix FTBFS with new poppler 24.06 (LP: #2070403):
22diff --git a/debian/patches/2011_ffmpeg-7.patch b/debian/patches/2011_ffmpeg-7.patch
23new file mode 100644
24index 0000000..5e8af21
25--- /dev/null
26+++ b/debian/patches/2011_ffmpeg-7.patch
27@@ -0,0 +1,27 @@
28+Description: Fix build with FFmpeg 7
29+Author: Nicola Ferralis <feranick@hotmail.com>
30+Bug-Debian: https://bugs.launchpad.net/debian/+source/openboard
31+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/openboard/+bug/2079134
32+Forwarded: not-needed
33+Last-Update: 2024-09-20
34+---
35+--- openboard-1.6.4+dfsg.orig/src/podcast/ffmpeg/UBFFmpegVideoEncoder.cpp
36++++ openboard-1.6.4+dfsg/src/podcast/ffmpeg/UBFFmpegVideoEncoder.cpp
37+@@ -520,7 +520,7 @@ bool UBFFmpegVideoEncoder::init()
38+ }
39+
40+ // Buffer for resampled/converted audio
41+- mAudioOutBuffer = av_audio_fifo_alloc(c->sample_fmt, c->channels, c->frame_size);
42++ mAudioOutBuffer = av_audio_fifo_alloc(c->sample_fmt, c->ch_layout.nb_channels, c->frame_size);
43+ }
44+
45+
46+@@ -640,7 +640,7 @@ void UBFFmpegVideoEncoder::processAudio(
47+ int outSamplesLineSize;
48+
49+ ret = av_samples_alloc_array_and_samples(&outSamples, &outSamplesLineSize,
50+- codecContext->channels, outSamplesCount,
51++ codecContext->ch_layout.nb_channels, outSamplesCount,
52+ codecContext->sample_fmt, 0);
53+ if (ret < 0) {
54+ qWarning() << "Could not allocate audio samples" << avErrorToQString(ret);
55diff --git a/debian/patches/series b/debian/patches/series
56index 1a681fe..5fc238b 100644
57--- a/debian/patches/series
58+++ b/debian/patches/series
59@@ -12,3 +12,4 @@
60 1009_various-typo-fixes.patch
61 2010_fix-poppler2406-build.patch
62 0001_ffmpeg-5.patch
63+2011_ffmpeg-7.patch

Subscribers

People subscribed via source and target branches

to all changes: