Merge ~liushuyu-011/ubuntu/+source/nagios-plugins-rabbitmq:merge-lp2065200 into ubuntu/+source/nagios-plugins-rabbitmq:debian/sid

Proposed by Zixing Liu
Status: Needs review
Proposed branch: ~liushuyu-011/ubuntu/+source/nagios-plugins-rabbitmq:merge-lp2065200
Merge into: ubuntu/+source/nagios-plugins-rabbitmq:debian/sid
Diff against target: 78 lines (+39/-1)
4 files modified
debian/changelog (+18/-0)
debian/control (+2/-1)
debian/patches/get-stats-from-idle-server.patch (+18/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Simon Quigley (community) Approve
Canonical Server Pending
Review via email: mp+465795@code.launchpad.net

Description of the change

This MP merges nagios-plugins-rabbitmq changes from Debian unstable into Ubuntu Oracular.

PPA build: https://launchpad.net/~liushuyu-011/+archive/ubuntu/misc/+sourcepub/16127204/+listing-archive-extra

To post a comment you must log in.
Revision history for this message
Simon Quigley (tsimonq2) wrote :

> vitrage-tempest-plugin changes

copy/paste slower ;)

review: Approve
Revision history for this message
Zixing Liu (liushuyu-011) wrote :

> > vitrage-tempest-plugin changes
>
> copy/paste slower ;)

I swear I have checked that before hitting the submit button.
Probably missed this one

Unmerged commits

7bb0c6c... by Zixing Liu

finalize changelog

f4e8882... by Zixing Liu

update-maintainer

75784a1... by Zixing Liu

reconstruct-changelog

9695a26... by Zixing Liu

merge-changelogs

77c960d... by Zixing Liu

d/p/get-stats-from-idle-server.patch: move the code changes to a patch ...

... after the package switched to 3.0 format

e0b4fd9... by Zixing Liu

    - Avoid breaking to get stats from an idle server that has
      no socket descriptors open (LP: #1787110)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 8a64f88..eaa0d0a 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,14 @@
6+nagios-plugins-rabbitmq (1:1.2.0-2.5ubuntu1) oracular; urgency=medium
7+
8+ * Merge with Debian unstable (LP: #2065200). Remaining changes:
9+ - Avoid breaking to get stats from an idle server that has
10+ no socket descriptors open (LP #1787110)
11+ * New Changes:
12+ - d/p/get-stats-from-idle-server.patch: move the code changes to a patch
13+ after the package switched to 3.0 format
14+
15+ -- Zixing Liu <zixing.liu@canonical.com> Wed, 08 May 2024 12:00:31 -0600
16+
17 nagios-plugins-rabbitmq (1:1.2.0-2.5) unstable; urgency=medium
18
19 * Non-maintainer upload.
20@@ -23,6 +34,13 @@ nagios-plugins-rabbitmq (1:1.2.0-2.3) unstable; urgency=medium
21
22 -- Holger Levsen <holger@debian.org> Tue, 05 Jan 2021 16:22:06 +0100
23
24+nagios-plugins-rabbitmq (1:1.2.0-2.2ubuntu1) eoan; urgency=medium
25+
26+ * Avoid breaking to get stats from an idle server that has
27+ no socket descriptors open (LP: #1787110)
28+
29+ -- Christian Ehrhardt <christian.ehrhardt@canonical.com> Tue, 24 Sep 2019 10:54:04 +0200
30+
31 nagios-plugins-rabbitmq (1:1.2.0-2.2) unstable; urgency=medium
32
33 * Non-maintainer upload.
34diff --git a/debian/control b/debian/control
35index 3ace5b6..7f37ae3 100644
36--- a/debian/control
37+++ b/debian/control
38@@ -1,7 +1,8 @@
39 Source: nagios-plugins-rabbitmq
40 Section: net
41 Priority: optional
42-Maintainer: Cyril Bouthors <cyril@boutho.rs>
43+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
44+XSBC-Original-Maintainer: Cyril Bouthors <cyril@boutho.rs>
45 Uploaders: Cyril Bouthors <cyb@debian.org>, Cyril Bouthors <cyril@bouthors.org>
46 Build-Depends: debhelper-compat (= 13), rsync, libmodule-build-perl
47 Standards-Version: 3.9.5
48diff --git a/debian/patches/get-stats-from-idle-server.patch b/debian/patches/get-stats-from-idle-server.patch
49new file mode 100644
50index 0000000..1453d6f
51--- /dev/null
52+++ b/debian/patches/get-stats-from-idle-server.patch
53@@ -0,0 +1,18 @@
54+Description: don't rise critical error when $used is 0
55+Author: Thierno IB. BARRY <ibrahima.br@gmail.com>
56+Origin: upstream, https://github.com/nagios-plugins-rabbitmq/nagios-plugins-rabbitmq/commit/caabebdf4e1d820c19b7d7fa8e682848f22834e9
57+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/nagios-plugins-rabbitmq/+bug/1787110
58+Applied-Upstream: commit, caabebdf4e1d820c19b7d7fa8e682848f22834e9
59+Last-Update: 2024-05-08
60+---
61+--- nagios-plugins-rabbitmq-1.2.0.orig/scripts/check_rabbitmq_server
62++++ nagios-plugins-rabbitmq-1.2.0/scripts/check_rabbitmq_server
63+@@ -165,7 +165,7 @@ sub check {
64+ my $warning = shift;
65+ my $critical = shift;
66+
67+- if (!$p || !$used) {
68++ if (!$p || !defined($used)) {
69+ $p->nagios_exit( return_code=>CRITICAL, message=>'Unable to get values for '.$label);
70+ } else {
71+ my $value = percent($used, $limit);
72diff --git a/debian/patches/series b/debian/patches/series
73index 89a561b..da8cd89 100644
74--- a/debian/patches/series
75+++ b/debian/patches/series
76@@ -1 +1,2 @@
77 namespace.patch
78+get-stats-from-idle-server.patch

Subscribers

People subscribed via source and target branches