Merge ~liushuyu-011/ubuntu/+source/libcdio:ubuntu/devel into ubuntu/+source/libcdio:ubuntu/devel

Proposed by Zixing Liu
Status: Needs review
Proposed branch: ~liushuyu-011/ubuntu/+source/libcdio:ubuntu/devel
Merge into: ubuntu/+source/libcdio:ubuntu/devel
Diff against target: 52 lines (+30/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/arm-t64-redirect-fix.patch (+22/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Lucas Kanashiro (community) Approve
Review via email: mp+463629@code.launchpad.net

Description of the change

This MP fixes an FTBFS issue after armhf time_t 64-bit transition.

You can find a PPA build at https://launchpad.net/~liushuyu-011/+archive/ubuntu/misc/+sourcepub/15910749/+listing-archive-extra.

To post a comment you must log in.
Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

Thanks for this MP Zixing! LGTM, +1.

review: Approve
Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

Package uploaded:

Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading libcdio_2.1.0-4.1ubuntu1.dsc: done.
  Uploading libcdio_2.1.0-4.1ubuntu1.debian.tar.xz: done.
  Uploading libcdio_2.1.0-4.1ubuntu1_source.changes: done.
Successfully uploaded packages.

Unmerged commits

9d3e0ec... by Zixing Liu

changelog for t64 regression fix

01f3cb8... by Zixing Liu

d/p/arm-t64-redirect-fix.patch: add a patch to fix t64 regression

ed3eb62... by Steve Langasek

2.1.0-4.1build1 (patches unapplied)

Imported using git-ubuntu import.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 4970271..b3366e0 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,10 @@
6+libcdio (2.1.0-4.1ubuntu1) noble; urgency=medium
7+
8+ * debian/patches/arm-t64-redirect-fix.patch: Fix implicit declaration
9+ after armhf time_t transition.
10+
11+ -- Zixing Liu <zixing.liu@canonical.com> Wed, 03 Apr 2024 15:15:43 -0600
12+
13 libcdio (2.1.0-4.1build1) noble; urgency=medium
14
15 * No-change rebuild for CVE-2024-3094
16diff --git a/debian/patches/arm-t64-redirect-fix.patch b/debian/patches/arm-t64-redirect-fix.patch
17new file mode 100644
18index 0000000..e5667a2
19--- /dev/null
20+++ b/debian/patches/arm-t64-redirect-fix.patch
21@@ -0,0 +1,22 @@
22+Description: Fix implicit declaration after armhf time_t transition
23+Author: Zixing Liu <zixing.liu@canonical.com>
24+Forwarded: no
25+Last-Update: 2024-04-03
26+
27+Index: libcdio/lib/driver/_cdio_stdio.h
28+===================================================================
29+--- libcdio.orig/lib/driver/_cdio_stdio.h
30++++ libcdio/lib/driver/_cdio_stdio.h
31+@@ -22,6 +22,12 @@
32+
33+ #include "_cdio_stream.h"
34+
35++#include <features.h>
36++#if defined(_FILE_OFFSET_BITS) && defined(__REDIRECT) && (_FILE_OFFSET_BITS == 64)
37++#define lseek64 lseek
38++#define fseeko64 fseeko
39++#endif
40++
41+ /*!
42+ Initialize a new stdio stream reading from pathname.
43+ A pointer to the stream is returned or NULL if there was an error.
44diff --git a/debian/patches/series b/debian/patches/series
45index d2a6512..386da3a 100644
46--- a/debian/patches/series
47+++ b/debian/patches/series
48@@ -3,3 +3,4 @@ Drop-LIBCDIO_SOURCE_PATH-by-dropping-STRIP_FROM_PATH.patch
49 src-cdda-player.c-always-use-s-style-format-for-prin.patch
50 Correct-realpath-test-failure.patch
51 Use-getmntent-setmntent-for-reading-mounts.patch
52+arm-t64-redirect-fix.patch

Subscribers

People subscribed via source and target branches