Merge ~liushuyu-011/ubuntu/+source/kbd:ubuntu/devel into ubuntu/+source/kbd:ubuntu/devel

Proposed by Zixing Liu
Status: Merged
Merged at revision: 518cd1c467eb2a08b40c873fe67326e89befbdec
Proposed branch: ~liushuyu-011/ubuntu/+source/kbd:ubuntu/devel
Merge into: ubuntu/+source/kbd:ubuntu/devel
Diff against target: 48 lines (+26/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/Add-missing-headers.patch (+18/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Vladimir Petko (community) Approve
Review via email: mp+473534@code.launchpad.net

Description of the change

This merge proposal fixes kbd build with GCC 14 due to missing C standard library headers.

To post a comment you must log in.
Revision history for this message
Vladimir Petko (vpa1977) wrote :

- Please add the ftbfs bug and reference it in the patch/changelog
- Please forward the patch upstream and update the header.
- Please run quilt refresh on the patch.

review: Needs Fixing
Revision history for this message
Zixing Liu (liushuyu-011) wrote :

> - Please run quilt refresh on the patch.

$ quilt refresh
Patch debian/patches/Add-missing-headers.patch is unchanged

> - Please forward the patch upstream and update the header.

Now using upstream patch (the same change).

Revision history for this message
Vladimir Petko (vpa1977) wrote :

$ quilt --version
0.67
$quilt refresh
Refreshed patch Add-missing-headers.patch
$ git diff debian/patches/Add-missing-headers.patch
diff --git a/debian/patches/Add-missing-headers.patch b/debian/patches/Add-missing-headers.patch
index df8e073..8e2309c 100644
--- a/debian/patches/Add-missing-headers.patch
+++ b/debian/patches/Add-missing-headers.patch
@@ -3,10 +3,8 @@ Author: Andreas Henriksson <email address hidden>
 Origin: upstream, https://github.com/legionus/kbd/commit/d8ba05d190db2b4e410993ea241fcdc28e0128a2
 Last-Update: 2024-09-19
 ---
-Index: kbd/contrib/splitfont.c
-===================================================================
---- kbd.orig/contrib/splitfont.c
-+++ kbd/contrib/splitfont.c
+--- a/contrib/splitfont.c
++++ b/contrib/splitfont.c
 @@ -5,6 +5,8 @@
  #include <fcntl.h>
  #include <unistd.h>

Revision history for this message
Vladimir Petko (vpa1977) wrote :

Ran quilt refresh before upload.

Uploaded, Thank you.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 3807d24..c5ce0d1 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,10 @@
6+kbd (2.6.4-2ubuntu3) oracular; urgency=medium
7+
8+ * d/p/Add-missing-headers.patch: add a patch to fix FTBFS with GCC 14
9+ (LP: #2081329).
10+
11+ -- Zixing Liu <zixing.liu@canonical.com> Thu, 19 Sep 2024 11:27:01 -0600
12+
13 kbd (2.6.4-2ubuntu2) noble; urgency=medium
14
15 * No-change rebuild for CVE-2024-3094
16diff --git a/debian/patches/Add-missing-headers.patch b/debian/patches/Add-missing-headers.patch
17new file mode 100644
18index 0000000..df8e073
19--- /dev/null
20+++ b/debian/patches/Add-missing-headers.patch
21@@ -0,0 +1,18 @@
22+Description: Add missing headers to fix GCC 14 build
23+Author: Andreas Henriksson <andreas@fatal.se>
24+Origin: upstream, https://github.com/legionus/kbd/commit/d8ba05d190db2b4e410993ea241fcdc28e0128a2
25+Last-Update: 2024-09-19
26+---
27+Index: kbd/contrib/splitfont.c
28+===================================================================
29+--- kbd.orig/contrib/splitfont.c
30++++ kbd/contrib/splitfont.c
31+@@ -5,6 +5,8 @@
32+ #include <fcntl.h>
33+ #include <unistd.h>
34+ #include <sys/stat.h>
35++#include <string.h>
36++#include <stdlib.h>
37+
38+ void dosplit(int from, int to, char *fontbuf, int size, char *fontfile)
39+ {
40diff --git a/debian/patches/series b/debian/patches/series
41index e03c21e..3d3e5d5 100644
42--- a/debian/patches/series
43+++ b/debian/patches/series
44@@ -6,3 +6,4 @@ Support-KT_DEAD2-diacritics.patch
45
46 loadkeys_find_usable_console.diff
47 loadkeys_ckbcomp.diff
48+Add-missing-headers.patch

Subscribers

People subscribed via source and target branches