Merge ~liushuyu-011/ubuntu/+source/aptdaemon:ubuntu/devel into ubuntu/+source/aptdaemon:ubuntu/devel

Proposed by Zixing Liu
Status: Merged
Merge reported by: Zixing Liu
Merged at revision: ec453daaf5191546853b940dfaed11704796a50e
Proposed branch: ~liushuyu-011/ubuntu/+source/aptdaemon:ubuntu/devel
Merge into: ubuntu/+source/aptdaemon:ubuntu/devel
Diff against target: 30 lines (+10/-1)
2 files modified
debian/changelog (+9/-0)
debian/rules (+1/-1)
Reviewer Review Type Date Requested Status
Vladimir Petko (community) Approve
Review via email: mp+473537@code.launchpad.net

Description of the change

This merge proposal fixes aptdaemon after the Python 3.12 transition, where setuptools no longer provides test driver functionality.

To post a comment you must log in.
Revision history for this message
Zixing Liu (liushuyu-011) wrote :
Revision history for this message
Vladimir Petko (vpa1977) wrote :

Would it be possible to raise a bug / link existing setuptool bug in the changelog?

review: Needs Information
Revision history for this message
Zixing Liu (liushuyu-011) wrote :

> Would it be possible to raise a bug / link existing setuptool bug in the changelog?

It seems to have been previously missed from the Python 3.12 transition tracking.

Revision history for this message
Vladimir Petko (vpa1977) wrote :

Uploaded, thank you!!!

Minor nit: added punctuation in the changelog.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 96dbe65..98d9f26 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,12 @@
6+aptdaemon (1.1.1+bzr982-0ubuntu46) oracular; urgency=medium
7+
8+ * Fix build-time tests (LP: #2082000)
9+ - d/rules: Use nosetest3 as the test driver as setuptools has
10+ removed test command.
11+ - d/rules: Disabled cdrom tests, as they are very flaky
12+
13+ -- Zixing Liu <zixing.liu@canonical.com> Thu, 19 Sep 2024 12:35:48 -0600
14+
15 aptdaemon (1.1.1+bzr982-0ubuntu45) oracular; urgency=medium
16
17 * Fix invalid escape sequences (LP: #2071678).
18diff --git a/debian/rules b/debian/rules
19index 9c56cfb..2033a19 100755
20--- a/debian/rules
21+++ b/debian/rules
22@@ -15,7 +15,7 @@ ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
23 test-python%:
24 # wait until previous xvfb-run has finished
25 while [ -e /tmp/.X99-lock ]; do sleep 1; done
26- xvfb-run python$* setup.py test -vv
27+ xvfb-run nosetests3 --process-restartworker --process-timeout=60 --exclude=test_cdrom
28
29 override_dh_auto_test: $(PYTHON3:%=test-python%)
30 endif

Subscribers

People subscribed via source and target branches