Merge ~litios/ubuntu-cve-tracker:oval/customer-merge-support into ubuntu-cve-tracker:master

Proposed by David Fernandez Gonzalez
Status: Merged
Merged at revision: 383919df1bf2335e784811f72b57fa340e34bb4a
Proposed branch: ~litios/ubuntu-cve-tracker:oval/customer-merge-support
Merge into: ubuntu-cve-tracker:master
Diff against target: 30 lines (+3/-5)
2 files modified
scripts/cve_lib.py (+1/-4)
scripts/oval_lib.py (+2/-1)
Reviewer Review Type Date Requested Status
Eduardo Barretto Approve
Review via email: mp+462311@code.launchpad.net

Description of the change

Once generating OVAL, we only had support for the elder parent being a base Ubuntu release.

This PR allows other cases.

To post a comment you must log in.
Revision history for this message
Eduardo Barretto (ebarretto) wrote :

lgtm, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/scripts/cve_lib.py b/scripts/cve_lib.py
2index a3104fa..91aa59c 100755
3--- a/scripts/cve_lib.py
4+++ b/scripts/cve_lib.py
5@@ -878,10 +878,7 @@ def release_version(rel):
6 try:
7 version = details["version"]
8 except KeyError:
9- rel = release_progenitor(rel)
10- _, _, _, details = get_subproject_details(rel)
11- if details:
12- version = details["version"]
13+ return release_version(release_progenitor(rel))
14 return version
15
16 def release_ppas(rel):
17diff --git a/scripts/oval_lib.py b/scripts/oval_lib.py
18index 17650ee..6273d08 100755
19--- a/scripts/oval_lib.py
20+++ b/scripts/oval_lib.py
21@@ -528,7 +528,8 @@ class OvalGenerator:
22 def _init_ids(self, release):
23 # e.g. codename for trusty/esm should be trusty
24 self.release = release
25- self.release_codename = cve_lib.release_progenitor(self.release) if cve_lib.release_progenitor(self.release) else self.release.replace('/', '_')
26+ self.release_codename = cve_lib.release_progenitor(self.release) if cve_lib.release_progenitor(self.release) else self.release
27+ self.release_codename = self.release_codename.replace('/', '_')
28 self.release_name = cve_lib.release_name(self.release)
29
30 self.parent_releases = list()

Subscribers

People subscribed via source and target branches