Merge ~litios/ubuntu-cve-tracker:add-static-built-using into ubuntu-cve-tracker:master
Status: | Merged |
---|---|
Merged at revision: | 9017273fae6f79c1ef72330c9bbd7fb5175c0c8a |
Proposed branch: | ~litios/ubuntu-cve-tracker:add-static-built-using |
Merge into: | ubuntu-cve-tracker:master |
Diff against target: |
117 lines (+35/-30) 1 file modified
scripts/source_map.py (+35/-30) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Eduardo Barretto | Approve | ||
Alex Murray | Needs Fixing | ||
Review via email: mp+435735@code.launchpad.net |
Description of the change
The tool to report the packages used during the building uses Built-Using to gather them. This is not the only case for other formats like Golang.
This is a proposition to extend this to tag 'Static-
As this is not the only tool using the functions from source_map I've tried to minimize changes to prevent other scripts from breaking and make it as generic as possible.
On a side note, the script process-cves, on line 1092, use these functions to tell the user about packages that may need to be rebuilt. I would also like to propose adding the static check there too. The worst-case scenario would be nothing extra to report.
overall lgtm, I made some small comments and I would wait for Steve's review.