Merge lp:~litianzhi-1/ubiquity/lp1762097 into lp:ubiquity

Proposed by litianzhi
Status: Merged
Approved by: Mathieu Trudel-Lapierre
Approved revision: 6609
Merged at revision: 6611
Proposed branch: lp:~litianzhi-1/ubiquity/lp1762097
Merge into: lp:ubiquity
Diff against target: 77 lines (+6/-11)
5 files modified
autopilot/ubiquity_autopilot_tests/tests/__init__.py (+1/-1)
debian/real-po/zh_CN.po (+1/-5)
debian/ubiquity.templates (+1/-1)
gui/gtk/stepPrepare.ui (+2/-3)
tests/test_gtkui.py (+1/-1)
To merge this branch: bzr merge lp:~litianzhi-1/ubiquity/lp1762097
Reviewer Review Type Date Requested Status
Mathieu Trudel-Lapierre Approve
Review via email: mp+342985@code.launchpad.net

Commit message

In Autopilot/ubiquity_autopilot_tests/tests/__init__.py, Gui/gtk/stepPrepare.ui, Tests/test_gtkui.py, the unification of the prepare_foss_disclaimer id in the three files is used, because debian/ubiquity.templates and ubiquity/plugins/ubi-prepare.py use prepare_foss_disclaimer.

In gui/gtk/stepPrepare.ui and debian/ubiquity.templates, the deletion of the last extra space of the string 'This software is subject to license'.

In debian/real-po/zh_CN.po, delete the line that caused the translation to fail

Description of the change

fix bug lp1762097

To post a comment you must log in.
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'autopilot/ubiquity_autopilot_tests/tests/__init__.py'
2--- autopilot/ubiquity_autopilot_tests/tests/__init__.py 2018-04-04 06:36:01 +0000
3+++ autopilot/ubiquity_autopilot_tests/tests/__init__.py 2018-04-11 06:32:28 +0000
4@@ -269,7 +269,7 @@
5 GtkAlignment, BuilderName='stepPrepare')
6
7 objList = [
8- 'prepare_foss_disclaimer_license',
9+ 'prepare_foss_disclaimer',
10 'prepare_minimal_install',
11 'prepare_download_updates',
12 'prepare_nonfree_software'
13
14=== modified file 'debian/real-po/zh_CN.po'
15--- debian/real-po/zh_CN.po 2018-03-28 12:52:26 +0000
16+++ debian/real-po/zh_CN.po 2018-04-11 06:32:28 +0000
17@@ -1493,14 +1493,10 @@
18 #. Type: text
19 #. Description
20 #: ../ubiquity.templates:228001
21-#, fuzzy
22-#| msgid ""
23-#| "Install third-party software for graphics and Wi-Fi hardware, Flash, MP3 "
24-#| "and other media"
25 msgid ""
26 "Install third-party software for graphics and Wi-Fi hardware and additional "
27 "media formats"
28-msgstr "为图形或无线硬件,以及MP3和其它媒体安装第三方软件"
29+msgstr "为图形或无线硬件,以及其它媒体格式安装第三方软件"
30
31 #. Type: text
32 #. Description
33
34=== modified file 'debian/ubiquity.templates'
35--- debian/ubiquity.templates 2018-03-28 12:52:10 +0000
36+++ debian/ubiquity.templates 2018-04-11 06:32:28 +0000
37@@ -1161,7 +1161,7 @@
38 Template: ubiquity/text/prepare_foss_disclaimer
39 Type: text
40 _Description:
41- This software is subject to license terms included with its documentation. Some is proprietary.
42+ This software is subject to license terms included with its documentation. Some is proprietary.
43
44 Template: ubiquity/text/prepare_nonfree_software
45 Type: text
46
47=== modified file 'gui/gtk/stepPrepare.ui'
48--- gui/gtk/stepPrepare.ui 2018-03-28 12:49:42 +0000
49+++ gui/gtk/stepPrepare.ui 2018-04-11 06:32:28 +0000
50@@ -289,12 +289,11 @@
51 <property name="can_focus">False</property>
52 <property name="orientation">vertical</property>
53 <child>
54- <object class="GtkLabel" id="prepare_foss_disclaimer_license">
55+ <object class="GtkLabel" id="prepare_foss_disclaimer">
56 <property name="visible">True</property>
57 <property name="can_focus">False</property>
58 <property name="margin_top">3</property>
59- <property name="label" translatable="yes">This software is subject to license terms included with its documentation. Some is proprietary.
60-</property>
61+ <property name="label" translatable="yes">This software is subject to license terms included with its documentation. Some is proprietary.</property>
62 <property name="wrap">True</property>
63 <property name="ellipsize">middle</property>
64 <property name="xalign">0</property>
65
66=== modified file 'tests/test_gtkui.py'
67--- tests/test_gtkui.py 2016-10-06 23:30:02 +0000
68+++ tests/test_gtkui.py 2018-04-11 06:32:28 +0000
69@@ -135,7 +135,7 @@
70 'label_global_error',
71 'warning_password_label', 'label1', 'secureboot_label',
72 # secure boot
73- 'disable_secureboot', 'prepare_foss_disclaimer_license',
74+ 'disable_secureboot', 'prepare_foss_disclaimer',
75 'label_free_space', 'label_required_space',
76 'label_download_updates',
77 ]

Subscribers

People subscribed via source and target branches

to status/vote changes: