Terminator

Merge lp:~listener13/terminator/window-role into lp:terminator/trunk

  1. window-role
  2. Merge into trunk
Proposed by Dmitry Soldatov
Status: Merged
Merge reported by: Chris Jones
Merged at revision: not available
Proposed branch: lp:~listener13/terminator/window-role
Merge into: lp:terminator/trunk
Diff against target: 52 lines (+8/-2)
2 files modified
terminator (+3/-1)
terminatorlib/terminator.py (+5/-1)
To merge this branch: bzr merge lp:~listener13/terminator/window-role
Reviewer Review Type Date Requested Status
Chris Jones (community) Approve
Review via email: mp+15173@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Dmitry Soldatov (listener13) wrote :

Added ability to set custom X window property WM_WINDOW_ROLE. Useful for window manager to identify different terminal apps.

Revision history for this message
Chris Jones (cmsj) wrote :

This is pretty noninvasive and clearly useful, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'terminator'
2--- terminator 2009-06-29 22:51:53 +0000
3+++ terminator 2009-11-23 19:55:20 +0000
4@@ -97,6 +97,8 @@
5 inside the terminal")
6 parser.add_option ("--working-directory", metavar="DIR",
7 dest="working_directory", help="Set the terminal's working directory")
8+ parser.add_option ("-r", "--role", dest="role",
9+ help="Set custom WM_WINDOW_ROLE property")
10 for item in ['--sm-client-id', '--sm-config-prefix', '--screen']:
11 parser.add_option (item, dest="dummy", action="store", help=SUPPRESS_HELP)
12
13@@ -160,7 +162,7 @@
14 dbg ('profile_cb: settled on profile: "%s"' % options.profile)
15 term = Terminator (options.profile, command, options.fullscreen,
16 options.maximise, options.borderless, options.no_gconf,
17- options.geometry, options.hidden, options.forcedtitle)
18+ options.geometry, options.hidden, options.forcedtitle, options.role)
19
20 term.origcwd = origcwd
21
22
23=== modified file 'terminatorlib/terminator.py'
24--- terminatorlib/terminator.py 2009-10-22 19:47:51 +0000
25+++ terminatorlib/terminator.py 2009-11-23 19:55:20 +0000
26@@ -45,6 +45,7 @@
27 _window = None
28 text = None
29 _forced = False
30+ _role = None
31
32 def __init__ (self, window):
33 self._window = window
34@@ -168,7 +169,7 @@
35
36 def __init__ (self, profile = None, command = None, fullscreen = False,
37 maximise = False, borderless = False, no_gconf = False,
38- geometry = None, hidden = False, forcedtitle = None):
39+ geometry = None, hidden = False, forcedtitle = None, role=None):
40 self.profile = profile
41 self.command = command
42
43@@ -267,6 +268,9 @@
44 self.set_closebutton_style ()
45
46 self.window = gtk.Window ()
47+ if role:
48+ self.window.set_role(role)
49+
50 self.windowtitle = TerminatorWindowTitle (self.window)
51 if forcedtitle:
52 self.windowtitle.force_title (forcedtitle)