Merge lp:~linuxjedi/libdrizzle/5.1-fix-wine into lp:libdrizzle

Proposed by Andrew Hutchings
Status: Rejected
Rejected by: Andrew Hutchings
Proposed branch: lp:~linuxjedi/libdrizzle/5.1-fix-wine
Merge into: lp:libdrizzle
Diff against target: 30 lines (+4/-4)
2 files modified
bootstrap.sh (+2/-2)
docs/compiling.rst (+2/-2)
To merge this branch: bzr merge lp:~linuxjedi/libdrizzle/5.1-fix-wine
Reviewer Review Type Date Requested Status
Brian Aker Pending
Review via email: mp+142282@code.launchpad.net

Description of the change

Switch to wine instead of wineconsole for tests

This is due to the following bug which remains unfixed:

http://bugs.winehq.org/show_bug.cgi?id=25390

For us the limited console support in the wine exec is more than adequate

To post a comment you must log in.

Unmerged revisions

85. By Andrew Hutchings

Switch to wine instead of wineconsole for tests

This is due to the following bug which remains unfixed:

http://bugs.winehq.org/show_bug.cgi?id=25390

For us the limited console support in the wine exec is more than adequate

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bootstrap.sh'
2--- bootstrap.sh 2013-01-07 05:33:02 +0000
3+++ bootstrap.sh 2013-01-08 10:51:21 +0000
4@@ -535,8 +535,8 @@
5 assert_file 'Makefile'
6
7 mingw32-make || die 'mingw32-make failed'
8- if command_exists wineconsole; then
9- TESTS_ENVIRONMENT='wineconsole --backend=curses'
10+ if command_exists wine; then
11+ TESTS_ENVIRONMENT='wine'
12 mingw32-make 'check' || die 'mingw32-make check failed'
13 fi
14 }
15
16=== modified file 'docs/compiling.rst'
17--- docs/compiling.rst 2013-01-06 23:47:56 +0000
18+++ docs/compiling.rst 2013-01-08 10:51:21 +0000
19@@ -72,9 +72,9 @@
20
21 "PATH"=str(2):"C:\\windows\\system32;C:\\windows;C:\\windows\\system32\\wbem;Z:\\usr\\i686-w64-mingw32\\sys-root\\mingw\\bin"
22
23-#. Run the test suite as follows (see :ref:`test-suite` for more details and needed environment variables when running the test suite)::
24+#. Run the test suite, it automatically sets ``TESTS_ENVIRONMENTS`` for you if you have wine installed (see :ref:`test-suite` for more details on running thetest suite)::
25
26- WINEARCH=win32 TESTS_ENVIRONMENT=wine make check
27+ TESTS_ENVIRONMENT=wine
28
29 Linking Your Application
30 ------------------------

Subscribers

People subscribed via source and target branches

to all changes:
to status/vote changes: