Merge lp:~linuxjedi/drizzle/drizzle-bug-550251 into lp:~drizzle-trunk/drizzle/development

Proposed by Andrew Hutchings
Status: Merged
Approved by: Brian Aker
Approved revision: 1747
Merged at revision: 1749
Proposed branch: lp:~linuxjedi/drizzle/drizzle-bug-550251
Merge into: lp:~drizzle-trunk/drizzle/development
Diff against target: 15 lines (+5/-1)
1 file modified
client/drizzle.cc (+5/-1)
To merge this branch: bzr merge lp:~linuxjedi/drizzle/drizzle-bug-550251
Reviewer Review Type Date Requested Status
Drizzle Merge Team Pending
Review via email: mp+34805@code.launchpad.net

Description of the change

If an error occurred during results fetch in drizzle client the result set was not freed correctly ending in segfault upon client end.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'client/drizzle.cc'
2--- client/drizzle.cc 2010-08-28 19:47:15 +0000
3+++ client/drizzle.cc 2010-09-07 21:01:40 +0000
4@@ -2764,7 +2764,11 @@
5 return 0;
6
7 if (drizzle_con_error(&con)[0])
8- return put_error(&con, result);
9+ {
10+ int ret= put_error(&con, result);
11+ drizzle_result_free(result);
12+ return ret;
13+ }
14 return 0;
15 }
16