sqlitebrowser-recipe

sqlitebrowser-recipe:coverity_scan

  1. Git
  2. lp:sqlitebrowser-recipe
  3. coverity_scan
Last commit made on 2019-05-09
Get this branch:
git clone -b coverity_scan https://git.launchpad.net/sqlitebrowser-recipe

Branch merges

Branch information

Name:
coverity_scan
Repository:
lp:sqlitebrowser-recipe

Recent commits

ae4dbaf... by Martin Kleusberg <email address hidden>

travis: Automatically send builds to Coverity for analysation

afee3ca... by Martin Kleusberg <email address hidden>

Support more field separators and quote chars in the CSV import

This adds support for more characters as field separator and for quoting
in the CSV import. Before this we only supported ASCII characters, with
this we support all characters which when UTF-8 encoded require up to
16 bits.

See issue #1860.

cec6b82... by Martin Kleusberg <email address hidden>

Fix loading of last used settings in Import CSV dialog

Fix the loading of the last used import settings in the Import CSV
dialog when the "Other" option has been used in one of the dropdown
boxes.

c70a1fc... by Manuel Gomez

Close version range to apply workaround for QTBUG-73721

It appeared in Qt version 5.12.0 and it is supposed to be fixed in 5.12.3.

See issue #1658

d1621e3... by Martin Kleusberg <email address hidden>

Fix qmake build

f877f8a... by Scott Furry

Resolve Github Issue #1867 - Spurious Empty Filename message.

Problem traced to QFile::exist() producing message when passed an empty QString.
Fix is to test QString length before any QFile::exist() usage with that string.

d54b820... by Scott Furry <email address hidden>

Shadowed Variable Warnings (#1864)

Compile with ALL_WARNINGS using GCC 8.2.1.
Encountered approximately dozen warnings with this pattern:

    [path to sqlitebrowser root]/src/[somesourcefile]:line:cursor: warning: declaration
 of ‘data’ shadows a member of ‘ClassName’ [-Wshadow]
            OtherDataType data = ....line of code at line given above...
                          ^~~~
    In file included from /usr/include/qt5/QtWidgets/qdialog.h:44,
                     from /usr/include/qt5/QtWidgets/QDialog:1,
                     ...other sources in project
    /usr/include/qt5/QtWidgets/qwidget.h:733:18: note: shadowed declaration is here
         QWidgetData *data;
                      ^~~~

It appears there is a variable named 'data' within Qt global scope. Using 'data`
as a variable name, even one limited in scope to small lamda expressions, causes
compiler some grief.

Commit resolves the warnings in affected files. No problems apparent during execution.
Requires CSV stress-testing.

800a8da... by Scott Furry

Normalize qhexedit.h include path

Include path used for QHexEdit in EditDialog.cpp is "implementation specific"
to how DB4S uses the QHexEdit library. Change is to make usage of library
more generic.

c61e172... by Martin Kleusberg <email address hidden>

Attempt to fix the build on some platforms - again

See issue #1879.

64a596a... by Martin Kleusberg <email address hidden>

Use even less Qt containers