Code review comment for lp:~linuxdcpp-team/linuxdcpp/0707-core

Revision history for this message
Steven Sheehy (steven-sheehy) wrote :

Some of the issues are just questions I have about of some of the new functionality. Here's the list:

1) Download cancelled but segmented downloads still shows up in finished download
2) Shouldn't files show up in finished downloads only once they are 100% complete?
3) What is the point of the group by users in finished *loads? Seems unnecessary and doesn't look aesthetically pleasing with two rows of tabs.
4) When users first connect they show up as a parent row, then once they connect they move to be a child
5) Download filelist from a user who just finished a segment for another file results in filelist download showing up as a child of the non-filelist download
6) Incorrect time left calculated sometimes (ex. 0:-3:-31) (I saw it with a download with only one source, not sure if this is relevant)
7) Instead of copyListValue_gui and copyTreeValue_gui, would it be better just to have copyValue_gui and let overloading do its work?
8) Should we be using namespace dcpp or use the namespace specifier everywhere to make it clear where the object comes from?

If you make any changes, please make them to the 0707 branch as I am in the process of merging to trunk.

« Back to merge proposal