Merge lp:~lindekleiv/kazam/unstable into lp:kazam/unstable

Proposed by Olav Andreas Lindekleiv
Status: Rejected
Rejected by: David Klasinc
Proposed branch: lp:~lindekleiv/kazam/unstable
Merge into: lp:kazam/unstable
Diff against target: 124 lines (+18/-10)
4 files modified
kazam/app.py (+2/-2)
kazam/backend/gstreamer.py (+1/-1)
kazam/backend/prefs.py (+9/-0)
kazam/frontend/preferences.py (+6/-7)
To merge this branch: bzr merge lp:~lindekleiv/kazam/unstable
Reviewer Review Type Date Requested Status
David Klasinc Pending
Review via email: mp+153671@code.launchpad.net

Description of the change

Fixes autosave directory being reset after restarting Kazam.

To post a comment you must log in.
Revision history for this message
David Klasinc (bigwhale) wrote :

Rejecting old requests. This was fixed in a different manner.

Unmerged revisions

390. By Olav Andreas Lindekleiv

Use autosave_*_dir instead of *_dest for video and pictures.

389. By Olav Andreas Lindekleiv

Fixes Kazam not saving video_dest and picture_dest directories.

388. By Launchpad Translations on behalf of kazam-team

Launchpad automatic translations update.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'kazam/app.py'
2--- kazam/app.py 2013-02-28 16:51:10 +0000
3+++ kazam/app.py 2013-03-16 22:31:23 +0000
4@@ -596,7 +596,7 @@
5 def cb_flush_done(self, widget):
6 if self.main_mode == MODE_SCREENCAST and prefs.autosave_video:
7 logger.debug("Autosaving enabled.")
8- fname = get_next_filename(prefs.video_dest,
9+ fname = get_next_filename(prefs.autosave_video_dir,
10 prefs.autosave_video_file,
11 CODEC_LIST[prefs.codec][3])
12
13@@ -633,7 +633,7 @@
14 self.indicator.menuitem_quit.set_sensitive(True)
15
16 if prefs.autosave_picture:
17- fname = get_next_filename(prefs.picture_dest, prefs.autosave_picture_file, ".png")
18+ fname = get_next_filename(prefs.autosave_picture_dir, prefs.autosave_picture_file, ".png")
19 self.grabber.autosave(fname)
20 else:
21 self.grabber.save_capture(self.old_pic_path)
22
23=== modified file 'kazam/backend/gstreamer.py'
24--- kazam/backend/gstreamer.py 2013-03-06 06:50:23 +0000
25+++ kazam/backend/gstreamer.py 2013-03-16 22:31:23 +0000
26@@ -51,7 +51,7 @@
27 def __init__(self):
28 GObject.GObject.__init__(self)
29
30- self.temp_fh = tempfile.mkstemp(prefix="kazam_", dir=prefs.video_dest, suffix=".movie")
31+ self.temp_fh = tempfile.mkstemp(prefix="kazam_", dir=prefs.autosave_video_dir, suffix=".movie")
32 self.tempfile = self.temp_fh[1]
33 self.muxer_tempfile = "{0}.mux".format(self.tempfile)
34 self.pipeline = Gst.Pipeline()
35
36=== modified file 'kazam/backend/prefs.py'
37--- kazam/backend/prefs.py 2013-02-28 07:32:48 +0000
38+++ kazam/backend/prefs.py 2013-03-16 22:31:23 +0000
39@@ -77,9 +77,11 @@
40 self.pa_q = None
41 self.framerate = 15
42 self.autosave_video = False
43+ self.autosave_video_dir = None
44 self.autosave_video_file = None
45
46 self.autosave_picture = False
47+ self.autosave_picture_dir = None
48 self.autosave_picture_file = None
49 self.shutter_sound = True
50 self.shutter_type = 0
51@@ -208,9 +210,11 @@
52
53 self.autosave_video = self.config.getboolean("main", "autosave_video")
54 self.autosave_video_file = self.config.get("main", "autosave_video_file")
55+ self.autosave_video_dir = self.config.get("main", "autosave_video_dir")
56
57 self.autosave_picture = self.config.getboolean("main", "autosave_picture")
58 self.autosave_picture_file = self.config.get("main", "autosave_picture_file")
59+ self.autosave_picture_dir = self.config.get("main", "autosave_picture_dir")
60
61 self.shutter_sound = self.config.getboolean("main", "shutter_sound")
62 self.shutter_type = int(self.config.get("main", "shutter_type"))
63@@ -234,10 +238,15 @@
64 self.config.set("main", "counter", self.countdown_timer)
65 self.config.set("main", "codec", self.codec)
66 self.config.set("main", "framerate", self.framerate)
67+
68 self.config.set("main", "autosave_video", self.autosave_video)
69+ self.config.set("main", "autosave_video_dir", self.autosave_video_dir)
70 self.config.set("main", "autosave_video_file", self.autosave_video_file)
71+
72 self.config.set("main", "autosave_picture", self.autosave_picture)
73+ self.config.set("main", "autosave_picture_dir", self.autosave_picture_dir)
74 self.config.set("main", "autosave_picture_file", self.autosave_picture_file)
75+
76 self.config.set("main", "shutter_sound", self.shutter_sound)
77 self.config.set("main", "shutter_type", self.shutter_type)
78
79
80=== modified file 'kazam/frontend/preferences.py'
81--- kazam/frontend/preferences.py 2013-03-06 06:50:23 +0000
82+++ kazam/frontend/preferences.py 2013-03-16 22:31:23 +0000
83@@ -167,7 +167,7 @@
84
85 self.entry_autosave_video.set_text(prefs.autosave_video_file)
86
87- self.filechooser_video.set_current_folder(prefs.video_dest)
88+ self.filechooser_video.set_current_folder(prefs.autosave_video_dir)
89
90 if prefs.shutter_sound:
91 self.switch_shutter_sound.set_active(True)
92@@ -190,7 +190,7 @@
93
94 self.entry_autosave_picture.set_text(prefs.autosave_picture_file)
95
96- self.filechooser_picture.set_current_folder(prefs.picture_dest)
97+ self.filechooser_picture.set_current_folder(prefs.autosave_picture_dir)
98
99 #
100 # Crappy code below ... Can this be done some other way?
101@@ -319,8 +319,8 @@
102 self.entry_autosave_video.set_sensitive(False)
103
104 def cb_filechooser_video(self, widget):
105- prefs.video_dest = self.filechooser_video.get_current_folder()
106- logger.debug("Video folder set to: {0}".format(prefs.video_dest))
107+ prefs.autosave_video_dir = self.filechooser_video.get_current_folder()
108+ logger.debug("Video autosave folder set to: {0}".format(prefs.autosave_video_dir))
109
110 def cb_entry_autosave_video(self, widget):
111 prefs.autosave_video_file = widget.get_text()
112@@ -355,10 +355,9 @@
113 self.entry_autosave_picture.set_sensitive(False)
114
115 def cb_filechooser_picture(self, widget):
116- prefs.picture_dest = self.filechooser_picture.get_current_folder()
117- logger.debug("Picture folder set to: {0}".format(prefs.picture_dest))
118+ prefs.autosave_picture_dir = self.filechooser_picture.get_current_folder()
119+ logger.debug("Picture autosave folder set to: {0}".format(prefs.autosave_picture_dir))
120
121 def cb_entry_autosave_picture(self, widget):
122 prefs.autosave_picture_file = widget.get_text()
123 logger.debug("Picture autosave file set to: {0}".format(prefs.autosave_picture_file))
124-

Subscribers

People subscribed via source and target branches