Merge lp:~linaro-validation/lava-dashboard-tool/nonlegacy-rpc-and-auth-support into lp:lava-dashboard-tool
Proposed by
Zygmunt Krynicki
Status: | Merged |
---|---|
Merged at revision: | 154 |
Proposed branch: | lp:~linaro-validation/lava-dashboard-tool/nonlegacy-rpc-and-auth-support |
Merge into: | lp:lava-dashboard-tool |
Diff against target: | 0 lines |
To merge this branch: | bzr merge lp:~linaro-validation/lava-dashboard-tool/nonlegacy-rpc-and-auth-support |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Linaro Validation Team | Pending | ||
Review via email: mp+68143@code.launchpad.net |
Description of the change
Add support for authenticated and non-legacy APIs, see the commit message for more details.
To post a comment you must log in.
This looks basically fine. I'm not sure an extra roundtrip per invocation is really a good idea -- we notice things like that down on the bottom of the world. Would it not be possible to assume the new api and if that fails with something 404ish, try the old url? Or just upgrade to using the new API -- how many legacy installations of the dashboard are there in reality?
But no opposition to landing this as is.