Merge lp:~linaro-validation/lava-dashboard-tool/nonlegacy-rpc-and-auth-support into lp:lava-dashboard-tool

Proposed by Zygmunt Krynicki
Status: Merged
Merged at revision: 154
Proposed branch: lp:~linaro-validation/lava-dashboard-tool/nonlegacy-rpc-and-auth-support
Merge into: lp:lava-dashboard-tool
Diff against target: 0 lines
To merge this branch: bzr merge lp:~linaro-validation/lava-dashboard-tool/nonlegacy-rpc-and-auth-support
Reviewer Review Type Date Requested Status
Linaro Validation Team Pending
Review via email:

Description of the change

Add support for authenticated and non-legacy APIs, see the commit message for more details.

To post a comment you must log in.
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

This looks basically fine. I'm not sure an extra roundtrip per invocation is really a good idea -- we notice things like that down on the bottom of the world. Would it not be possible to assume the new api and if that fails with something 404ish, try the old url? Or just upgrade to using the new API -- how many legacy installations of the dashboard are there in reality?

But no opposition to landing this as is.

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

There are two causes for latency:

1) Calling server.dashboard.version()
2) Calling server.system.listMethods()

We could probably ignore both for some time and stop supporting launch-control but IMHO it's too early for that yet. We could try to work around that with more complex code (one multicall would tell us both the version and the methods) (at one cost of latency) but I don't think we need to over-complicate that just yet.

156. By Zygmunt Krynicki

Move the call to use_non_legacy_api earlier

157. By Zygmunt Krynicki

Bump version to 0.6

Preview Diff



People subscribed via source and target branches