Linaro GCC

Merge lp:~linaro-toolchain-dev/gcc-linaro/sms_add_missing_free_op into lp:gcc-linaro/4.6

  1. sms_add_missing_free_op
  2. Merge into 4.6
Proposed by Revital Eres
Status: Rejected
Rejected by: Michael Hope
Proposed branch: lp:~linaro-toolchain-dev/gcc-linaro/sms_add_missing_free_op
Merge into: lp:gcc-linaro/4.6
To merge this branch: bzr merge lp:~linaro-toolchain-dev/gcc-linaro/sms_add_missing_free_op
Reviewer Review Type Date Requested Status
Michael Hope Disapprove
Review via email: mp+85535@code.launchpad.net

Description of the change

Backport from trunk -r182271:
SMS: Add missing free operation in mark_loop_unsched

To post a comment you must log in.
Revision history for this message
Michael Hope (michaelh1) wrote :

cbuild has taken a snapshot of this branch at r106848 and queued it for build.

The diff against the ancestor r106846 is available at:
 http://builds.linaro.org/toolchain/snapshots/gcc-linaro-4.6+bzr106848~eres~sms_add_missing_free_op.diff

and will be built on the following builders:
 a9-builder armv5-builder i686 x86_64

You can track the build queue at:
 http://ex.seabright.co.nz/helpers/scheduler

cbuild-snapshot: gcc-linaro-4.6+bzr106848~eres~sms_add_missing_free_op
cbuild-ancestor: lp:gcc-linaro+bzr106846
cbuild-state: check

Revision history for this message
Michael Hope (michaelh1) wrote :

cbuild had trouble building this on x86_64-natty-cbuild217-oort1-x86_64r1.

See the *failed.txt logs under the build results at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.6+bzr106848~eres~sms_add_missing_free_op/logs/x86_64-natty-cbuild217-oort1-x86_64r1

../../../gcc-linaro-4.6/gcc/modulo-sched-pressure.c: In function 'update_reg_moves_pressure_info':
../../../gcc-linaro-4.6/gcc/modulo-sched-pressure.c:146:39: error: subscripted value is neither array nor pointer
../../../gcc-linaro-4.6/gcc/modulo-sched-pressure.c:148:41: error: subscripted value is neither array nor pointer
../../../gcc-linaro-4.6/gcc/modulo-sched-pressure.c: In function 'calc_liveness':
../../../gcc-linaro-4.6/gcc/modulo-sched-pressure.c:211:7: warning: unused variable 'link'

The test suite results were not checked.

cbuild-checked: x86_64-natty-cbuild217-oort1-x86_64r1

review: Needs Fixing
Revision history for this message
Michael Hope (michaelh1) wrote :

cbuild successfully built this on armv7l-natty-cbuild217-tcpanda06-cortexa9r1.

The build results are available at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.6+bzr106848~eres~sms_add_missing_free_op/logs/armv7l-natty-cbuild217-tcpanda06-cortexa9r1

-PASS: gfortran.dg/allocatable_function_1.f90 -O0 scan-tree-dump-times original "free" 10
+FAIL: gfortran.dg/allocatable_function_1.f90 -O0 scan-tree-dump-times original "free" 10
-PASS: gfortran.dg/allocatable_function_1.f90 -O1 scan-tree-dump-times original "free" 10
+FAIL: gfortran.dg/allocatable_function_1.f90 -O1 scan-tree-dump-times original "free" 10
-PASS: gfortran.dg/allocatable_function_1.f90 -O2 scan-tree-dump-times original "free" 10
+FAIL: gfortran.dg/allocatable_function_1.f90 -O2 scan-tree-dump-times original "free" 10
-PASS: gfortran.dg/allocatable_function_1.f90 -O3 -fomit-frame-pointer scan-tree-dump-times original "free" 10
+FAIL: gfortran.dg/allocatable_function_1.f90 -O3 -fomit-frame-pointer scan-tree-dump-times original "free" 10
-PASS: gfortran.dg/allocatable_function_1.f90 -O3 -fomit-frame-pointer -funroll-all-loops -finline-functions scan-tree-dump-times original "free" 10
+FAIL: gfortran.dg/allocatable_function_1.f90 -O3 -fomit-frame-pointer -funroll-all-loops -finline-functions scan-tree-dump-times original "free" 10
-PASS: gfortran.dg/allocatable_function_1.f90 -O3 -fomit-frame-pointer -funroll-loops scan-tree-dump-times original "free" 10
+FAIL: gfortran.dg/allocatable_function_1.f90 -O3 -fomit-frame-pointer -funroll-loops scan-tree-dump-times original "free" 10
-PASS: gfortran.dg/allocatable_function_1.f90 -O3 -g scan-tree-dump-times original "free" 10
+FAIL: gfortran.dg/allocatable_function_1.f90 -O3 -g scan-tree-dump-times original "free" 10
-PASS: gfortran.dg/allocatable_function_1.f90 -Os scan-tree-dump-times original "free" 10
+FAIL: gfortran.dg/allocatable_function_1.f90 -Os scan-tree-dump-times original "free" 10

These are probably due to the branch having 'free' in the name.

The full diff is at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.6+bzr106848~eres~sms_add_missing_free_op/logs/armv7l-natty-cbuild217-tcpanda06-cortexa9r1/testsuite-diff.txt

The full testsuite results are at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.6+bzr106848~eres~sms_add_missing_free_op/logs/armv7l-natty-cbuild217-tcpanda06-cortexa9r1/gcc-testsuite.txt

cbuild-checked: armv7l-natty-cbuild217-tcpanda06-cortexa9r1

Revision history for this message
Michael Hope (michaelh1) wrote :

cbuild successfully built this on i686-natty-cbuild217-oort2-i686r1.

The build results are available at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.6+bzr106848~eres~sms_add_missing_free_op/logs/i686-natty-cbuild217-oort2-i686r1

-PASS: gfortran.dg/allocatable_function_1.f90 -O0 scan-tree-dump-times original "free" 10
+FAIL: gfortran.dg/allocatable_function_1.f90 -O0 scan-tree-dump-times original "free" 10
-PASS: gfortran.dg/allocatable_function_1.f90 -O1 scan-tree-dump-times original "free" 10
+FAIL: gfortran.dg/allocatable_function_1.f90 -O1 scan-tree-dump-times original "free" 10
-PASS: gfortran.dg/allocatable_function_1.f90 -O2 scan-tree-dump-times original "free" 10
+FAIL: gfortran.dg/allocatable_function_1.f90 -O2 scan-tree-dump-times original "free" 10
-PASS: gfortran.dg/allocatable_function_1.f90 -O3 -fomit-frame-pointer scan-tree-dump-times original "free" 10
+FAIL: gfortran.dg/allocatable_function_1.f90 -O3 -fomit-frame-pointer scan-tree-dump-times original "free" 10
-PASS: gfortran.dg/allocatable_function_1.f90 -O3 -fomit-frame-pointer -funroll-all-loops -finline-functions scan-tree-dump-times original "free" 10
+FAIL: gfortran.dg/allocatable_function_1.f90 -O3 -fomit-frame-pointer -funroll-all-loops -finline-functions scan-tree-dump-times original "free" 10
-PASS: gfortran.dg/allocatable_function_1.f90 -O3 -fomit-frame-pointer -funroll-loops scan-tree-dump-times original "free" 10
+FAIL: gfortran.dg/allocatable_function_1.f90 -O3 -fomit-frame-pointer -funroll-loops scan-tree-dump-times original "free" 10
-PASS: gfortran.dg/allocatable_function_1.f90 -O3 -g scan-tree-dump-times original "free" 10
+FAIL: gfortran.dg/allocatable_function_1.f90 -O3 -g scan-tree-dump-times original "free" 10
-PASS: gfortran.dg/allocatable_function_1.f90 -Os scan-tree-dump-times original "free" 10
+FAIL: gfortran.dg/allocatable_function_1.f90 -Os scan-tree-dump-times original "free" 10

These are probably due to the branch having 'free' in the name.

The full diff is at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.6+bzr106848~eres~sms_add_missing_free_op/logs/i686-natty-cbuild217-oort2-i686r1/testsuite-diff.txt

The full testsuite results are at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.6+bzr106848~eres~sms_add_missing_free_op/logs/i686-natty-cbuild217-oort2-i686r1/gcc-testsuite.txt

cbuild-checked: i686-natty-cbuild217-oort2-i686r1

Revision history for this message
Michael Hope (michaelh1) wrote :

This branch includes the free and pressure patches. Superseded by lp:~michaelh1/gcc-linaro/sms-free-bbs.

review: Disapprove

Subscribers

People subscribed via source and target branches