Merge lp:~linaro-infrastructure/linaro-ci-dashboard/test-changes-additions into lp:linaro-ci-dashboard

[Deepti B. Kalakeri]

Organizing Django Tests into directories.
Adding some client response tests and modifying the __init__.py to include the tests.

[Stevan Radaković (stevanr)]

Hey Deepti,

Thanks for finalizing the test changes. Only one thing bothers me here. If I remove the decorator line from our code, these tests will still pass. Can we accommodate the tests so that they actually fail in this case?
I think adding the 'not_auth' test for index page would do the trick...

review: Needs Fixing (code)

[lp:~linaro-infrastructure/linaro-ci-dashboard/test-changes-additions]

10. By Deepti B. Kalakeri on 2012-07-10

Adding a test test_response_index_when_user_not_auth_by_login_required which fails when decorator is missing

[Deepti B. Kalakeri (deeptik)]

Added test test_response_index_when_user_not_auth_by_login_required which check this and fails if accidentally login_required() decorator is removed.

Thanks!!!
Deepti.

[Stevan Radaković (stevanr)]

Thanks Deepti.
Looks good.
Approve +1

review: Approve

=== added directory 'dashboard/frontend/tests'
=== added file 'dashboard/frontend/tests/__init__.py'
--- dashboard/frontend/tests/__init__.py	1970-01-01 00:00:00 +0000
+++ dashboard/frontend/tests/__init__.py	2012-07-10 14:09:20 +0000
@@ -0,0 +1,10 @@
+from dashboard.frontend.tests.test_views import *  
+from dashboard.frontend.tests.test_clientresponse import *  
+
+      
+#starts the test suite  
+__test__= {  
+           'HomePageViewTests': HomePageViewTest,
+           'IndexViewTests': IndexViewTest,
+           'ClientResponseTests': ClientResponseTests,
+           }  

=== added file 'dashboard/frontend/tests/test_clientresponse.py'
--- dashboard/frontend/tests/test_clientresponse.py	1970-01-01 00:00:00 +0000
+++ dashboard/frontend/tests/test_clientresponse.py	2012-07-10 14:09:20 +0000
@@ -0,0 +1,64 @@
+#!/usr/bin/env python
+# Copyright (C) 2012 Linaro
+#
+# This file is part of linaro-ci-dashboard.
+#
+# linaro-ci-dashboard is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# linaro-ci-dashboard is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU Affero General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with linaro-ci-dashboard.  If not, see <http://www.gnu.org/licenses/>.
+
+from django.test import TestCase
+from django.contrib.auth.models import User, Group
+from django.test.client import Client
+
+class ClientResponseTests(TestCase):
+
+    def setUp(self):
+        self.client = Client()
+        self.user = 'someuser'
+        self.passwd = 'somepasswd'
+        self.email = '[e-mail]'
+        self.group = 'somegroup'
+        self.user = User.objects.create_user(self.user,
+                    self.email, self.passwd)
+        self.group = Group.objects.create(name=self.group)
+
+    def tearDown(self):
+        user = User.objects.filter(username=self.user)
+        group = Group.objects.filter(name=self.group)
+        if user:
+            user.delete()
+        if group:
+            group.delete()
+
+    # Test case should fail if the login_required decorator source code
+    # in index_view.py is removed.  
+    def test_response_index_when_user_not_auth_by_login_required(self):
+        response = self.client.get('/index/')
+        self.assertNotEqual(200, response.status_code)
+
+    def test_response_home_when_user_not_auth_by_login_required(self):
+        response = self.client.get('/home/')
+        self.assertNotIn(str(self.user), response.content)
+
+    def test_response_with_invalid_user(self):
+        passwd = 'invalid_passwd'
+        login_value = self.client.login(username=self.user, password=passwd)
+        self.assertEqual(login_value, False)
+
+    def test_response_when_user_authed(self):
+        self.client.login(username=self.user, password=self.passwd)
+        response = self.client.get('/')
+        self.assertIn(str(self.user), response.content)
+        response = self.client.get('/home/')
+        self.assertIn(str(self.user), response.content)
+

=== renamed file 'dashboard/frontend/tests.py' => 'dashboard/frontend/tests/test_views.py'