Merge lp:~linaro-infrastructure/linaro-ci-dashboard/admin-app-openid into lp:linaro-ci-dashboard

[Stevan Radaković]

Add admin openID support.
Add manage.py command 'setsuperuser' for enabling openID users to be set as system admins.

[lp:~linaro-infrastructure/linaro-ci-dashboard/admin-app-openid]

20. By Stevan Radaković on 2012-07-06

Add tests for setsuperuser command.

[Deepti B. Kalakeri (deeptik)]

changes looks good. We could probably change the command to be named as setasadmin or setassuperuser or setasstaff which immediately gives a sense of what the command actually does.

[Данило Шеган (danilo)]

Please resolve conflicts on this and then it's good to land.

review: Approve

[lp:~linaro-infrastructure/linaro-ci-dashboard/admin-app-openid]

21. By Stevan Radaković on 2012-07-09

Merging trunk and resolving conflicts.

=== added directory 'dashboard/frontend/management'
=== added file 'dashboard/frontend/management/__init__.py'
=== added directory 'dashboard/frontend/management/commands'
=== added file 'dashboard/frontend/management/commands/__init__.py'
=== added file 'dashboard/frontend/management/commands/setsuperuser.py'
--- dashboard/frontend/management/commands/setsuperuser.py	1970-01-01 00:00:00 +0000
+++ dashboard/frontend/management/commands/setsuperuser.py	2012-07-09 11:09:20 +0000
@@ -0,0 +1,40 @@
+# Copyright (C) 2012 Linaro
+#
+# This file is part of linaro-ci-dashboard.
+#
+# linaro-ci-dashboard is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# linaro-ci-dashboard is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU Affero General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with linaro-ci-dashboard.  If not, see <http://www.gnu.org/licenses/>.
+# Django settings for dashboard project.
+
+from django.core.management.base import BaseCommand, CommandError
+from django.contrib.auth.models import User
+
+
+class Command(BaseCommand):
+    args = '<username username ...>'
+    help = 'Sets specified user as superuser of the dashboard admin app'
+
+    def handle(self, *args, **options):
+        for username in args:
+            self.find_and_update_user(username)
+            self.stdout.write('Successfully updated user "%s" \n' % username)
+
+    def find_and_update_user(self, username):
+        try:
+            user = User.objects.get(username=username)
+        except User.DoesNotExist:
+            raise CommandError('User "%s" does not exist' % username)
+
+        user.is_staff = True
+        user.is_superuser = True
+        user.save()

=== modified file 'dashboard/frontend/tests.py'
--- dashboard/frontend/tests.py	2012-07-06 12:30:37 +0000
+++ dashboard/frontend/tests.py	2012-07-09 11:09:20 +0000
@@ -15,10 +15,12 @@
 #
 # You should have received a copy of the GNU Affero General Public License
 # along with linaro-ci-dashboard.  If not, see <http://www.gnu.org/licenses/>.
-
+from django.core.management.base import CommandError
+from django.contrib.auth.models import User
 from django.test import TestCase
 from mock import Mock, patch
 
+import frontend.management.commands.setsuperuser as setsuperuser
 from frontend.views.home_page_view import HomePageView
 from frontend.views.index_view import IndexView
 
@@ -39,3 +41,22 @@
         index_view.request = "some request data"
         context = IndexView.get_context_data(index_view)
         self.assertEqual(context['request'], "some request data")
+
+
+class SetsuperuserCommandTest(TestCase):
+
+    def setUp(self):
+        self.command = setsuperuser.Command()
+
+    def test_find_and_update_user_non_existing(self):
+        self.assertRaises(CommandError,
+                          self.command.find_and_update_user,
+                          ("non_existing_user"))
+
+    def test_find_and_update_user(self):
+        user = User(username="existing_user")
+        user.save()
+        self.command.find_and_update_user("existing_user")
+        user = User.objects.get(username="existing_user")
+        self.assertEquals(user.is_staff, True)
+        self.assertEquals(user.is_superuser, True)

=== modified file 'dashboard/settings.py'
--- dashboard/settings.py	2012-07-06 12:49:00 +0000
+++ dashboard/settings.py	2012-07-09 11:09:20 +0000
@@ -147,6 +147,7 @@
 LOGIN_URL = '/openid/login/'
 OPENID_SSO_SERVER_URL = 'https://login.launchpad.net/'
 OPENID_LAUNCHPAD_TEAMS_MAPPING_AUTO = True
+OPENID_USE_AS_ADMIN_LOGIN = True
 
 # A sample logging configuration. The only tangible logging
 # performed by this configuration is to send an email to