Merge lp:~linaro-infrastructure/cbuild/sort-filelists-for-size into lp:cbuild

[Paul Sokolovsky]

Sort filelists for running thru size, du, as part of "run" step and "*-run.txt" lo, because otherwise the order is random which complicates comparing results of different builds. This came out when validating LAVA builds, cf. for example http://cbuild.validation.linaro.org/build/gcc-linaro-4.7-2013.01/logs/armv7l-precise-cbuild446-tcpanda11-cortexa9hfr1/gcc-run.txt and http://cbuild.validation.linaro.org/build/gcc-linaro-4.7-2013.01/logs/armv7l-precise-cbuild448-lava-cortexa9hfr1/gcc-run.txt

[Christophe Lyon (christophe-lyon)]

Shouldn't you sort on file names instead? Or sort numerically (sort -n)?

[Paul Sokolovsky (pfalcon)]

Well, the sort is applied to results of "find" (possibly, filtered), so, those are file paths relative to some build dir, e.g. "gcc-linaro-4.7-2013.01/gcc/default/install/libexec/gcc/arm-linux-gnueabi/4.7.3/cc1objplus". IMHO, it makes full sense to sort on such path as is, hence "sort" without any arguments.

[Christophe Lyon (christophe-lyon)]

You are obviously right; I read the patch too quickly and was confused by the gcc-run.txt link which starts with file sizes. OK for me.

[Paul Sokolovsky (pfalcon)]

Thanks, merging it then to apply to next LAVA test build.

=== modified file 'lib/steps.mk'
--- lib/steps.mk	2013-01-26 09:14:43 +0000
+++ lib/steps.mk	2013-01-29 11:58:24 +0000
@@ -118,8 +118,8 @@
 
 # Default versions of the rules
 get-sizes:
-	ALL="$(shell find -L $(VBUILD)/install/ -executable -and -type f -exec file {} \; | grep ELF | awk -F: '{print $$1;}')"; \
-	LIBS="$(shell find -L $(VBUILD)/install/ -type f -name '*.a')"; \
+	ALL="$(shell find -L $(VBUILD)/install/ -executable -and -type f -exec file {} \; | grep ELF | awk -F: '{print $$1;}' | sort)"; \
+	LIBS="$(shell find -L $(VBUILD)/install/ -type f -name '*.a' | sort)"; \
 	strip $$ALL; \
 	size $$ALL > $(STEP).txt; \
 	echo du: >> $(STEP).txt; \