Merge lp:~linaro-foundations/linaro-ci/add-device-tree-build-support into lp:linaro-ci

[Avik Sil]

[Deepti B. Kalakeri (deeptik)]

On Mon, Apr 23, 2012 at 12:09 PM, Avik Sil <email address hidden> wrote:

> Avik Sil has proposed merging
> lp:~linaro-foundations/linaro-ci/add-device-tree-build-support into
> lp:linaro-ci.
>
> Requested reviews:
> Deepti B. Kalakeri (deeptik)
>
> For more details, see:
>
> https://code.launchpad.net/~linaro-foundations/linaro-ci/add-device-tree-build-support/+merge/103048<https://code.launchpad.net/%7Elinaro-foundations/linaro-ci/add-device-tree-build-support/+merge/103048>
> --
>
> https://code.launchpad.net/~linaro-foundations/linaro-ci/add-device-tree-build-support/+merge/103048<https://code.launchpad.net/%7Elinaro-foundations/linaro-ci/add-device-tree-build-support/+merge/103048>
> You are requested to review the proposed merge of
> lp:~linaro-foundations/linaro-ci/add-device-tree-build-support into
> lp:linaro-ci.
>
> === modified file 'jenkins_common_lib'
> --- jenkins_common_lib 2012-03-26 20:41:50 +0000
> +++ jenkins_common_lib 2012-04-23 06:38:20 +0000
> @@ -60,6 +60,7 @@
> yes "" | make ARCH=arm O=$pkg_dir KERNELVERSION="$kernel_version"
> KERNELRELEASE="$kernel_version" CROSS_COMPILE=arm-linux-gnueabi- oldconfig
> make ARCH=arm O=$pkg_dir KERNELVERSION="$kernel_version"
> KERNELRELEASE="$kernel_version" CROSS_COMPILE=arm-linux-gnueabi- -j$j_count
> uImage
> make ARCH=arm O=$pkg_dir KERNELVERSION="$kernel_version"
> KERNELRELEASE="$kernel_version" CROSS_COMPILE=arm-linux-gnueabi- -j$j_count
> modules
> + make ARCH=arm O=$pkg_dir KERNELVERSION="$kernel_version"
> KERNELRELEASE="$kernel_version" CROSS_COMPILE=arm-linux-gnueabi- -j$j_count
> dtbs
>

This is a universal script used for building all the trees. Hence, this
would fail the other builds which use this scripts if dt changes are not in
the tree.
Do you know if the dt can be built for arm-soc, linus, linux-next in the
same manner ?
You should probable enable building the device tree when for example
dt_build = 1.
You should refer to submit_job flag as to how to modify for such a flag

    make ARCH=arm O=$pkg_dir KERNELVERSION="$kernel_version"
> KERNELRELEASE="$kernel_version" CROSS_COMPILE=arm-linux-gnueabi-
> KBUILD_DEBARCH=armel V=1 deb-pkg
> END=$(date +%s)
> EXECUTION_TIME_IN_SEC=$(( $END - $START ))
>
>
>

--
Thanks and Regards,
Deepti

[Ricardo Salveti (rsalveti)]

I don't think that will break the other builds, as make dtbs is available since 3.0. At the case where we don't have device tree support, it'll just skill as it'll not find any target.

[Deepti B. Kalakeri (deeptik)]

Avik, last when you mentioned there was no support from lava for testing dt.
Is this the same now ?

[Данило Шеган (danilo)]

This has seen no movement for a full month, so I am rejecting it. If it is still relevant, please reopen it and provide the information Deepti has asked for.

[Данило Шеган (danilo)]

review: Needs Information

Unmerged revisions

60. By Avik Sil on 2012-04-23

Add device tree build support

=== modified file 'jenkins_common_lib'
--- jenkins_common_lib	2012-03-26 20:41:50 +0000
+++ jenkins_common_lib	2012-04-23 06:38:20 +0000
@@ -60,6 +60,7 @@
     yes "" | make ARCH=arm O=$pkg_dir KERNELVERSION="$kernel_version" KERNELRELEASE="$kernel_version" CROSS_COMPILE=arm-linux-gnueabi- oldconfig	
     make ARCH=arm O=$pkg_dir KERNELVERSION="$kernel_version" KERNELRELEASE="$kernel_version" CROSS_COMPILE=arm-linux-gnueabi- -j$j_count uImage
     make ARCH=arm O=$pkg_dir KERNELVERSION="$kernel_version" KERNELRELEASE="$kernel_version" CROSS_COMPILE=arm-linux-gnueabi- -j$j_count modules
+    make ARCH=arm O=$pkg_dir KERNELVERSION="$kernel_version" KERNELRELEASE="$kernel_version" CROSS_COMPILE=arm-linux-gnueabi- -j$j_count dtbs
     make ARCH=arm O=$pkg_dir KERNELVERSION="$kernel_version" KERNELRELEASE="$kernel_version" CROSS_COMPILE=arm-linux-gnueabi- KBUILD_DEBARCH=armel V=1 deb-pkg
     END=$(date +%s)
     EXECUTION_TIME_IN_SEC=$(( $END - $START ))