Code review comment for lp:~lin-yu/purchase-wkfl/add_purchase_po_price
Revision history for this message
| Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote | # |
review:
Needs Information
(code review, functionnal)
Hi Lin,
Thanks for the contribution ! A got some stuff I'm not sure about in this module.
1) The description only mention "Enable/Disable control on PO Price" it's a bit too short.
2) Lots of other fields (I mean not related to the control of price) is present on PO Line, like qty_received, qty_unreceived,.. Those field do not seems to me related to the purpose of the module.. I don't actually know if it really make sens to have them here. Any pointer ?
3) Field like modify_price do not seems to be used, sequence serve another purpose than the one I see in this module
What I suggest is that you firstly make a better explanation of the purpose and use of the module. Once done, we can discuss further on what to let in there and what not. On my own opinion, this module should only forbid to change the price in PO if not allowed for this supplier.
Best regards,