Merge ~lihuiguo/charm-homer-dashboard:bug/1951654 into charm-homer-dashboard:master

Proposed by Linda Guo
Status: Merged
Approved by: Eric Chen
Approved revision: b3e06c3cbceaf4e843d638cabaaaed406cf0b1bb
Merged at revision: 02833cb326132da3be30dfe54a5f747c0c12091e
Proposed branch: ~lihuiguo/charm-homer-dashboard:bug/1951654
Merge into: charm-homer-dashboard:master
Diff against target: 12 lines (+1/-0)
1 file modified
src/charm.py (+1/-0)
Reviewer Review Type Date Requested Status
Eric Chen Approve
Paul Goins Approve
Review via email: mp+424739@code.launchpad.net

Commit message

open dashboard link in new tab

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Paul Goins (vultaire) wrote :

LGTM

review: Approve
Revision history for this message
Eric Chen (eric-chen) :
review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 02833cb326132da3be30dfe54a5f747c0c12091e

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/charm.py b/src/charm.py
2index 87faa3a..583737b 100755
3--- a/src/charm.py
4+++ b/src/charm.py
5@@ -194,6 +194,7 @@ class HomerDashboardCharm(CharmBase):
6 "url": url,
7 "subtitle": subtitle,
8 "relation_id": rel_id,
9+ "target": "_blank",
10 }
11 # delete the app from homer config file if it exists.
12 self._delete_application_from_homer(name=name, rel_id=rel_id, group=group)

Subscribers

People subscribed via source and target branches

to all changes: