Merge ~lihuiguo/charm-grafana:bug/1928759 into charm-grafana:master

Proposed by Linda Guo
Status: Merged
Approved by: Xav Paice
Approved revision: c3946d7704717ea2780e8a29b2acc33a18d62eb1
Merged at revision: 7c515b78af17ab55e539b2410dac68e1ba1e1318
Proposed branch: ~lihuiguo/charm-grafana:bug/1928759
Merge into: charm-grafana:master
Diff against target: 13 lines (+1/-1)
1 file modified
src/templates/dashboards/prometheus/CephPools.json.j2 (+1/-1)
Reviewer Review Type Date Requested Status
Xav Paice Approve
Jose Guedez Approve
prod-jenkaas-bootstack (community) continuous-integration Approve
Review via email: mp+402881@code.launchpad.net

Commit message

show multiple ceph pools at once

Description of the change

the Grafana ceph pool dashboard shows per-pool metrics,
    but there's no way to see multiple pools at once.
    We would like to be able to see multiple pools stacked
    to be able to visually determine which pool is using up the most IOPS

To post a comment you must log in.
Revision history for this message
prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :

A CI job is currently in progress. A follow up comment will be added when it completes.

Revision history for this message
Canonical IS Mergebot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :

A CI job is currently in progress. A follow up comment will be added when it completes.

Revision history for this message
prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Linda Guo (lihuiguo) wrote :
Revision history for this message
prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Approve (continuous-integration)
Revision history for this message
Jose Guedez (jfguedez) wrote :

LGTM +1

review: Approve
Revision history for this message
Xav Paice (xavpaice) wrote :

+1

review: Approve
Revision history for this message
Canonical IS Mergebot (canonical-is-mergebot) wrote :

Change successfully merged at revision 7c515b78af17ab55e539b2410dac68e1ba1e1318

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/templates/dashboards/prometheus/CephPools.json.j2 b/src/templates/dashboards/prometheus/CephPools.json.j2
2index bb5a289..a39a418 100644
3--- a/src/templates/dashboards/prometheus/CephPools.json.j2
4+++ b/src/templates/dashboards/prometheus/CephPools.json.j2
5@@ -670,7 +670,7 @@
6 "hide": 0,
7 "includeAll": false,
8 "label": "Pool",
9- "multi": false,
10+ "multi": true,
11 "name": "pool",
12 "options": [],
13 "query": "label_values(ceph_pool_objects_total{job=\"$job\"}, pool)",

Subscribers

People subscribed via source and target branches