Merge lp:~lightdm-gtk-greeter-team/lightdm-gtk-greeter/g_unix_signal_add into lp:~lightdm-gtk-greeter-team/lightdm-gtk-greeter/trunk
Proposed by
Simon Steinbeiß
Status: | Merged |
---|---|
Merged at revision: | 265 |
Proposed branch: | lp:~lightdm-gtk-greeter-team/lightdm-gtk-greeter/g_unix_signal_add |
Merge into: | lp:~lightdm-gtk-greeter-team/lightdm-gtk-greeter/trunk |
Diff against target: |
25 lines (+1/-7) 1 file modified
src/lightdm-gtk-greeter.c (+1/-7) |
To merge this branch: | bzr merge lp:~lightdm-gtk-greeter-team/lightdm-gtk-greeter/g_unix_signal_add |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Sean Davis | Pending | ||
Review via email: mp+212746@code.launchpad.net |
Description of the change
This patch switches from the deprecated signal to g_unix_signal_add.
The problem of the greeter persisting into the session (as described in the bugreport mentioned in the commit) seems to be caused by a mix of RetainPermanent and the greeter not shutting down properly. According to Robert Ancell, this could be the case, because it's not safe to call pretty much anything from a signal handler. Instead, g_unix_signal_add runs from the main loop. ("LightDM would have sent you the signal, then the gtk_main_quit might have done something weird with a thread.")
To post a comment you must log in.