Merge lp:~lifeless/zope.publisher/start-request-event into lp:zope.publisher

[Robert Collins]

EndRequest events are nice, StartRequest events would be nice too. As tested as EndRequest (that is not at all :().

[Robert Collins (lifeless)]

See also https://bugs.edge.launchpad.net/zope.app.publication/+bug/598816

[Tres Seaver (tseaver)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> Robert Collins has proposed merging lp:~lifeless/zope.publisher/start-request-event into lp:zope.publisher.
>
> Requested reviews:
> ZTK steering group (ztk-steering-group)
>
>
> EndRequest events are nice, StartRequest events would be nice too. As tested as EndRequest (that is not at all :().
>

 +1

I presume that there is a correlated branch for zope.app.publication
which actually emits the new events.

Tres.
- --
===================================================================
Tres Seaver [phone] <email address hidden>
Palladion Software "Excellence by Design" http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkwmEkkACgkQ+gerLs4ltQ6z0gCgg5ZR0umpljBYIUgcdKTFKMc+
vyUAn0bo4rhrdB310cj9U+jtOgMkeFkl
=1DXE
-----END PGP SIGNATURE-----

[Robert Collins (lifeless)]

There would be but I couldn't find a bzr import of zope.app.publication, so I've done a regular patch, filed a bug for zope.app.publication and filed it at https://bugs.edge.launchpad.net/zope.app.publication/+bug/598816.

[Robert Collins (lifeless)]

Benji says this has been applied.

=== modified file 'CHANGES.txt'
--- CHANGES.txt	2010-06-10 05:26:47 +0000
+++ CHANGES.txt	2010-06-26 12:34:24 +0000
@@ -6,6 +6,10 @@
 
 - LP #131460: Make principal logging unicode safe.
 - Remove use of string exceptions in tests, http://bugs.debian.org/585343
+- Add IStartRequestEvent and StartRequestEvent for using in
+  zope.app.publication (matching up with IEndRequestEvent and EndRequestEvent).
+  This included refactoring to produce one definition of 'event with a request'
+  - IRequestEvent.
 
 3.12.3 (2010-04-30)
 -------------------

=== modified file 'src/zope/publisher/interfaces/__init__.py'
--- src/zope/publisher/interfaces/__init__.py	2010-06-03 16:27:40 +0000
+++ src/zope/publisher/interfaces/__init__.py	2010-06-26 12:34:24 +0000
@@ -463,18 +463,44 @@
     """
 
 
-class IEndRequestEvent(Interface):
-    """An event which gets sent when the publication is ended"""
-
-
-class EndRequestEvent(object):
+class IRequestEvent(Interface):
+    """An event which is about or for a request."""
+
+    request = Attribute("The request this event is about.")
+
+
+class IEndRequestEvent(IRequestEvent):
+    """An event which gets sent when the publication is ended."""
+
+
+class IStartRequestEvent(IRequestEvent):
+    """An event which gets sent before publication of a request."""
+
+
+class RequestEvent(object):
+    """Events for requests.
+    
+    :ivar request: The request the event is for.
+    """
+
+    def __init__(self, request):
+        self.request = request
+
+
+class EndRequestEvent(RequestEvent):
     """An event which gets sent when the publication is ended"""
 
     implements(IEndRequestEvent)
 
     def __init__(self, ob, request):
+        super(EndRequestEvent, self).__init__(request)
         self.object = ob
-        self.request = request
+
+
+class StartRequestEvent(RequestEvent):
+    """An event send when before publication of a request."""
+
+    implements(IStartRequestEvent)
 
 
 class ISkinType(IInterface):
@@ -497,11 +523,9 @@
     """
 
 
-class ISkinChangedEvent(Interface):
+class ISkinChangedEvent(IRequestEvent):
     """Event that gets triggered when the skin of a request is changed."""
 
-    request = Attribute("The request for which the skin was changed.")
-
 
 
 class IDefaultViewName(Interface):