Merge lp:~lifeless/python-oops-tools/amqp-polish into lp:python-oops-tools

Proposed by Robert Collins
Status: Merged
Approved by: Aaron Bentley
Approved revision: no longer in the source branch.
Merged at revision: 11
Proposed branch: lp:~lifeless/python-oops-tools/amqp-polish
Merge into: lp:python-oops-tools
Diff against target: 0 lines
To merge this branch: bzr merge lp:~lifeless/python-oops-tools/amqp-polish
Reviewer Review Type Date Requested Status
Aaron Bentley (community) Approve
Review via email:

Commit message

Handle broken req_var variables (with 1-length tuples).

Description of the change

More polish for weird/broken oopses - we're getting single-tuple elements [('field.blob',)] rather than [('field.blob', 'xxxx')].

These need to be recorded rather than fail-to-import.

We could have used a marker like 'UNKNOWN CONTENTS' but meh - couldn't decide so went with less typing.

To post a comment you must log in.
Revision history for this message
Aaron Bentley (abentley) wrote :

We should add a test for:

46 + parsed_oops['id'] = parsed_oops['id'].upper()

Other than that, this is fine to land.

review: Approve
11. By Robert Collins

Handle broken req_var variables (with 1-length tuples).

Preview Diff



People subscribed via source and target branches

to all changes: