Merge lp:~lifeless/launchpad/subunit into lp:launchpad/db-devel

[Robert Collins]

DB patch supporting subunit stream storage against branches.

Add storage space for subunit streams; will do things with it next cycle.

[Robert Collins (lifeless)]

Fine by me :P

review: Approve (db)

[Martin Pool (mbp)]

Is there a LEP giving context for this?

If these are going to be attached to merge proposals or queues as the comment suggests, perhaps a more general attachment object would be useful, with a MIME type that can say it is subunit.

review: Needs Information

[Robert Collins (lifeless)]

On Mon, Nov 29, 2010 at 4:30 PM, Martin Pool <email address hidden> wrote:
> Review: Needs Information
> Is there a LEP giving context for this?

Nope :)

> If these are going to be attached to merge proposals or queues as the comment suggests, perhaps a more general attachment object would be useful, with a MIME type that can say it is subunit.

These are the start of test result support in LP, not generic attachments.

-rob

[Stuart Bishop (stub)]

We need an index on stream too to keep the Librarian Garbage Collector happy.

Otherwise fine. patch-2208-33-0.sql

 review approve db
 merge approved

[Stuart Bishop (stub)]

review: Approve (db)

[Robert Collins (lifeless)]

Will
"+CREATE INDEX SubunitStream__stream__idx ON SubunitStream(stream);"

be sufficient?

[Stuart Bishop (stub)]

On Wed, Dec 1, 2010 at 1:22 PM, Robert Collins
<email address hidden> wrote:
> Will
> "+CREATE INDEX SubunitStream__stream__idx ON SubunitStream(stream);"
>
> be sufficient?

Yes.

--
Stuart Bishop <email address hidden>
http://www.stuartbishop.net/

=== modified file 'database/schema/comments.sql'
--- database/schema/comments.sql	2010-12-01 11:26:57 +0000
+++ database/schema/comments.sql	2010-12-02 01:47:15 +0000
@@ -136,6 +136,14 @@
 COMMENT ON COLUMN SeriesSourcePackageBranch.registrant IS 'The person who registered this link.';
 COMMENT ON COLUMN SeriesSourcePackageBranch.date_created IS 'The date this link was created.';
 
+-- SubunitStream
+
+COMMENT ON TABLE SubunitStream IS 'Raw gz compressed subunit streams.';
+COMMENT ON COLUMN SubunitStream.uploader IS 'The account used to upload the stream.';
+COMMENT ON COLUMN SubunitStream.date_created IS 'The date of the upload.';
+COMMENT ON COLUMN SubunitStream.branch IS 'The branch which the stream was created on/for/with.';
+COMMENT ON COLUMN SubunitStream.stream IS 'The library file alias which contains the stream content.';
+
 -- BranchSubscription
 
 COMMENT ON TABLE BranchSubscription IS 'An association between a person or team and a bazaar branch.';

=== added file 'database/schema/patch-2208-33-0.sql'
--- database/schema/patch-2208-33-0.sql	1970-01-01 00:00:00 +0000
+++ database/schema/patch-2208-33-0.sql	2010-12-02 01:47:15 +0000
@@ -0,0 +1,16 @@
+SET client_min_messages=ERROR;
+
+CREATE TABLE SubunitStream (
+    id           SERIAL PRIMARY KEY,
+    uploader     INTEGER NOT NULL REFERENCES Person(id),
+    date_created timestamp without time zone NOT NULL
+        DEFAULT (CURRENT_TIMESTAMP AT TIME ZONE 'UTC'),
+    branch       INTEGER NOT NULL REFERENCES Branch(id),
+    stream       INTEGER NOT NULL REFERENCES LibraryFileAlias(id)
+);
+
+CREATE INDEX SubunitStream__uploader_created__idx ON SubunitStream(uploader, date_created);
+CREATE INDEX SubunitStream__branch_created__idx ON SubunitStream(branch, date_created);
+CREATE INDEX SubunitStream__stream__idx ON SubunitStream(stream);
+
+INSERT INTO LaunchpadDatabaseRevision VALUES (2208, 33, 0);

=== modified file 'database/schema/security.cfg'
--- database/schema/security.cfg	2010-12-01 11:26:57 +0000
+++ database/schema/security.cfg	2010-12-02 01:47:15 +0000
@@ -281,6 +281,7 @@
 public.staticdiff                       = SELECT, INSERT, UPDATE
 public.structuralsubscription           = SELECT, INSERT, UPDATE, DELETE
 public.suggestivepotemplate             = SELECT, INSERT, DELETE
+public.subunitstream                    = SELECT, INSERT, UPDATE, DELETE
 public.temporaryblobstorage             = SELECT, INSERT, DELETE
 public.translationgroup                 = SELECT, INSERT, UPDATE
 public.translationimportqueueentry      = SELECT, INSERT, UPDATE, DELETE
@@ -346,6 +347,7 @@
 public.sourcepackagepublishinghistory   = SELECT
 public.sourcepackagerelease             = SELECT
 public.specification                    = SELECT
+public.subunitstream                    = SELECT
 public.translationmessage               = SELECT, INSERT, UPDATE
 public.translationtemplateitem          = SELECT
 
@@ -398,6 +400,7 @@
 public.product                          = SELECT
 public.productreleasefile               = SELECT
 public.project                          = SELECT
+public.subunitstream                    = SELECT
 public.shipitreport                     = SELECT
 public.shippingrun                      = SELECT
 public.sprint                           = SELECT

=== modified file 'lib/lp/code/doc/branch.txt'
--- lib/lp/code/doc/branch.txt	2010-10-06 18:53:53 +0000
+++ lib/lp/code/doc/branch.txt	2010-12-02 01:47:15 +0000
@@ -405,6 +405,7 @@
     sourcepackagerecipedata.base_branch
     sourcepackagerecipedatainstruction.branch
     specificationbranch.branch
+    subunitstream.branch
     translationtemplatesbuild.branch
 
 (Unfortunately, references can form a cycle-- note that