Launchpad itself

Merge lp:~lifeless/launchpad/soyuz into lp:launchpad

  1. soyuz
  2. Merge into devel
Proposed by Robert Collins
Status: Merged
Approved by: Robert Collins
Approved revision: no longer in the source branch.
Merged at revision: 11914
Proposed branch: lp:~lifeless/launchpad/soyuz
Merge into: lp:launchpad
Diff against target: 12 lines (+1/-1)
1 file modified
lib/lp/registry/model/distroseries.py (+1/-1)
To merge this branch: bzr merge lp:~lifeless/launchpad/soyuz
Reviewer Review Type Date Requested Status
Robert Collins (community) Approve
Review via email: mp+40693@code.launchpad.net

Description of the change

The previous change didn't quite drop SourcePackageName, with the result that it was retrieving 38K times as many rows as needed. OOps.

To post a comment you must log in.
Revision history for this message
Robert Collins (lifeless) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/registry/model/distroseries.py'
2--- lib/lp/registry/model/distroseries.py 2010-11-10 02:45:48 +0000
3+++ lib/lp/registry/model/distroseries.py 2010-11-12 06:43:56 +0000
4@@ -1001,7 +1001,7 @@
5 source_package_ids, self.distribution.all_distro_archive_ids,
6 active_publishing_status, self),
7 clauseTables=[
8- 'SourcePackageName', 'SourcePackagePublishingHistory'])
9+ 'SourcePackagePublishingHistory'])
10 return dict(
11 (self.getSourcePackage(release.sourcepackagename),
12 DistroSeriesSourcePackageRelease(self, release))