Launchpad itself

Merge lp:~lifeless/launchpad/paralleltests into lp:launchpad

  1. paralleltests
  2. Merge into devel
Proposed by Robert Collins
Status: Merged
Approved by: Robert Collins
Approved revision: no longer in the source branch.
Merged at revision: 13366
Proposed branch: lp:~lifeless/launchpad/paralleltests
Merge into: lp:launchpad
To merge this branch: bzr merge lp:~lifeless/launchpad/paralleltests
Reviewer Review Type Date Requested Status
Steve Kowalik (community) code Approve
Review via email: mp+66554@code.launchpad.net

Commit message

[r=stevenk][no-qa] More parallel test reliability. Isolate create-db calls with a lock and use a temporary template to reduce contention between workers.

Description of the change

More parallel test reliability. Move tests that were creating/dropping launchpad_ftest into base layer to get unique test ids; improve the isolation and locking around concurrent create-db calls using the same template (because postgresql hates it).

With this I can run -t canonical.database.postgresql reliably with --parallel, and most of --layer DatabaseLayer (the failures therein are shared directories for codehosting amongst other things.

To post a comment you must log in.
Revision history for this message
Jonathan Lange (jml) wrote :

Looks like the branch is broken.

Revision history for this message
Robert Collins (lifeless) wrote :

On Fri, Jul 1, 2011 at 11:00 PM, Jonathan Lange <email address hidden> wrote:
> Looks like the branch is broken.

The scanner is broken, the branch is fine.

Revision history for this message
Robert Collins (lifeless) wrote :

http://pastebin.com/gfuxTm7t

Revision history for this message
Steve Kowalik (stevenk) wrote :

This looks fine to my jetlag-adled brain.

review: Approve (code)