Code review comment for lp:~lifeless/launchpad/oops

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

This was not one of those rubber-stamp reviews. :-)

The biggest sticking point, if a small one, was the dead code left in there to document the expected future state of the code. Please resolve that situation as soon as possible, of course.

We found that Timeline.baseline was at risk of ambiguity, because the Timeline could in principle be created on-demand in the middle of handling a request. We considered always having a "Start timeline" action, but decided against it. Ultimately you went with the option of creating the Timeline early on when handling a request, so that the baseline is always more or less the time we start handling the request.

review: Approve

« Back to merge proposal