Merge lp:~lifeless/launchpad/malone into lp:launchpad

[Robert Collins]

Add a DISTINCT to the commentedbugs subselect for performance.

Fix bug 668138 by applying the distinct change from Stuarts recommendations which was sufficient alone to address things on qastaging.

[Robert Collins (lifeless)]

review: Approve

[Tim Penhey (thumper)]

review: Approve

[Tim Penhey (thumper)]

Rob, you forgot to tag your review "unreviewed" :-)

[Robert Collins (lifeless)]

On Thu, Nov 18, 2010 at 6:21 PM, Tim Penhey <email address hidden> wrote:
> Rob, you forgot to tag your review "unreviewed"  :-)

https://dev.launchpad.net/PolicyAndProcess/OptionalReviews -
activities, part 2 : just review yourself, to fit our toolchain.

-Rob

=== modified file 'lib/lp/bugs/model/bugtask.py'
--- lib/lp/bugs/model/bugtask.py	2010-11-09 08:43:34 +0000
+++ lib/lp/bugs/model/bugtask.py	2010-11-18 04:54:32 +0000
@@ -1836,7 +1836,7 @@
         if params.bug_commenter:
             bug_commenter_clause = """
             BugTask.id IN (
-                SELECT BugTask.id FROM BugTask, BugMessage, Message
+                SELECT DISTINCT BugTask.id FROM BugTask, BugMessage, Message
                 WHERE Message.owner = %(bug_commenter)s
                     AND Message.id = BugMessage.message
                     AND BugTask.bug = BugMessage.bug