Merge lp:~lifeless/launchpad/malone into lp:launchpad

Proposed by Robert Collins on 2010-11-18
Status: Merged
Approved by: Robert Collins on 2010-11-18
Approved revision: no longer in the source branch.
Merged at revision: 11936
Proposed branch: lp:~lifeless/launchpad/malone
Merge into: lp:launchpad
Diff against target: 12 lines (+1/-1)
1 file modified
lib/lp/bugs/model/bugtask.py (+1/-1)
To merge this branch: bzr merge lp:~lifeless/launchpad/malone
Reviewer Review Type Date Requested Status
Tim Penhey (community) Approve on 2010-11-18
Robert Collins (community) Approve on 2010-11-18
Review via email: mp+41127@code.launchpad.net

Commit Message

Add a DISTINCT to the commentedbugs subselect for performance.

Description of the Change

Fix bug 668138 by applying the distinct change from Stuarts recommendations which was sufficient alone to address things on qastaging.

To post a comment you must log in.
Robert Collins (lifeless) :
review: Approve
Tim Penhey (thumper) :
review: Approve
Tim Penhey (thumper) wrote :

Rob, you forgot to tag your review "unreviewed" :-)

Robert Collins (lifeless) wrote :

On Thu, Nov 18, 2010 at 6:21 PM, Tim Penhey <email address hidden> wrote:
> Rob, you forgot to tag your review "unreviewed"  :-)

https://dev.launchpad.net/PolicyAndProcess/OptionalReviews -
activities, part 2 : just review yourself, to fit our toolchain.

-Rob

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/bugs/model/bugtask.py'
2--- lib/lp/bugs/model/bugtask.py 2010-11-09 08:43:34 +0000
3+++ lib/lp/bugs/model/bugtask.py 2010-11-18 04:54:32 +0000
4@@ -1836,7 +1836,7 @@
5 if params.bug_commenter:
6 bug_commenter_clause = """
7 BugTask.id IN (
8- SELECT BugTask.id FROM BugTask, BugMessage, Message
9+ SELECT DISTINCT BugTask.id FROM BugTask, BugMessage, Message
10 WHERE Message.owner = %(bug_commenter)s
11 AND Message.id = BugMessage.message
12 AND BugTask.bug = BugMessage.bug