Merge lp:~lifeless/launchpad/generate-htaccess-speed into lp:launchpad
Proposed by
Robert Collins
on 2012-05-30
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Robert Collins on 2012-05-30 | ||||
| Approved revision: | no longer in the source branch. | ||||
| Merged at revision: | 15337 | ||||
| Proposed branch: | lp:~lifeless/launchpad/generate-htaccess-speed | ||||
| Merge into: | lp:launchpad | ||||
| Diff against target: | 0 lines | ||||
| To merge this branch: | bzr merge lp:~lifeless/launchpad/generate-htaccess-speed | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Robert Collins (community) | Approve on 2012-05-30 | ||
| Jonathan Lange (community) | Approve on 2012-05-30 | ||
|
Review via email:
|
|||
Commit Message
Eliminate late evaluation in htaccess file creation. Also eliminate exporting of tokens for invalid users.
Description of the Change
Eliminate late-evaluation in htaccess file creation. No tests (they are coming via work jml is doing), existing tests pass, so the contract is maintained, and we have manually observed a 5-fold improvement on 5000 subscriber ppas.
To post a comment you must log in.
| Jonathan Lange (jml) wrote : | # |
Although, I mildly resent you for taking the fun out of it for me. :P
| Jonathan Lange (jml) wrote : | # |
This resentment is easily outweighed by the fact that this is done and better than I'd have done it and I get to go to sleep soon.
| Robert Collins (lifeless) wrote : | # |
Not a self review, but as we haven't taught LP how to think emeritus devs are reviewers without spamming them yet... it becomes one technically.
review:
Approve
Thanks for nailing this. Only suggestion is to add a comment before 'tokens = list(tokens)' explaining why you are doing this.