Merge lp:~lifeless/launchpad/bug-734642 into lp:launchpad

Proposed by Robert Collins on 2011-03-15
Status: Merged
Merged at revision: 12595
Proposed branch: lp:~lifeless/launchpad/bug-734642
Merge into: lp:launchpad
Diff against target: 0 lines
To merge this branch: bzr merge lp:~lifeless/launchpad/bug-734642
Reviewer Review Type Date Requested Status
Tim Penhey (community) code Approve on 2011-03-15
William Grant code* 2011-03-15 Approve on 2011-03-15
Review via email:

Description of the change

Improve the query used for rosetta translations per experimentation in bug 734642

To post a comment you must log in.
William Grant (wgrant) wrote :

This looks reasonable. But can you simplify the WHERE clause creation? It looks like 'query' will now contain a single item, so ' AND '.join()ing it is probably pointless.

review: Approve (code*)
Tim Penhey (thumper) wrote :

I agree with William, and would like to suggest that you follow the general style and capitalise the SQL keywords within the query string.

review: Approve (code)

Preview Diff