Merge lp:~lifeless/launchpad/bug-726370 into lp:launchpad

Proposed by Robert Collins on 2011-03-03
Status: Merged
Approved by: Robert Collins on 2011-03-03
Approved revision: 12518
Merged at revision: 12521
Proposed branch: lp:~lifeless/launchpad/bug-726370
Merge into: lp:launchpad
Diff against target: 31 lines (+9/-0) 2 files modified
To merge this branch: bzr merge lp:~lifeless/launchpad/bug-726370
Reviewer Review Type Date Requested Status
Robert Collins (community) Approve on 2011-03-03
Review via email: mp+52009@code.launchpad.net

Commit Message

[r=lifeless][ui=none][bug=726370] Remove another cause of late person loading in BugTask:+index.

Description of the Change

Remove another cause of late person loading in BugTask:+index. May not entirely fix the scaling of the page.

To post a comment you must log in.
Robert Collins (lifeless) wrote :

Another block in the wall.

review: Approve

Preview Diff

1=== modified file 'lib/lp/bugs/browser/bugtask.py'
2--- lib/lp/bugs/browser/bugtask.py 2011-03-01 05:05:26 +0000
3+++ lib/lp/bugs/browser/bugtask.py 2011-03-03 06:28:16 +0000
4@@ -3168,6 +3168,13 @@
5 distro_series_set = getUtility(IDistroSeriesSet)
6 self.target_releases.update(
7 distro_series_set.getCurrentSourceReleases(distro_series_packages))
8+ ids = set()
9+ for release_person_ids in map(attrgetter('creatorID', 'maintainerID'),
10+ self.target_releases.values()):
11+ ids.update(release_person_ids)
12+ ids.discard(None)
13+ if ids:
14+ list(getUtility(IPersonSet).getPrecachedPersonsFromIDs(ids))
15
16 def getTargetLinkTitle(self, target):
17 """Return text to put as the title for the link to the target."""
18
19=== modified file 'lib/lp/soyuz/interfaces/sourcepackagerelease.py'
20--- lib/lp/soyuz/interfaces/sourcepackagerelease.py 2011-01-27 22:01:07 +0000
21+++ lib/lp/soyuz/interfaces/sourcepackagerelease.py 2011-03-03 06:28:16 +0000
22@@ -30,7 +30,9 @@
23 """A source package release, e.g. apache-utils 2.0.48-3"""
24
25 id = Attribute("SourcePackageRelease identifier")
26+ creatorID = Attribute("DB ID of creator")
27 creator = Attribute("Person that created this release")
28+ maintainerID = Attribute("DB ID of the maintainer")
29 maintainer = Attribute("The person in general responsible for this "
30 "release")
31 version = Attribute("A version string")