Merge lp:~lifeless/launchpad/bug-717394-3 into lp:launchpad

[Robert Collins]

[r=lifeless][bug=722421] Fix a regression in Bug._known_viewers causing late evaluation of all bugtasks and pillars on every bug shown in a bug search.

Fix a regression in Bug._known_viewers causing a full bugtask lookup for every row in a bugsearch - whether the bugs were private or public. https://bugs.launchpad.net/launchpad/+bug/702429/comments/3 describes this more.

[Robert Collins (lifeless)]

Self reviewing.

review: Approve

[Robert Collins (lifeless)]

See also bug 702429 which is mentioned in the rev (12156.8.20) that introduced the regression.

=== modified file 'lib/lp/bugs/model/bug.py'
--- lib/lp/bugs/model/bug.py	2011-02-17 01:03:34 +0000
+++ lib/lp/bugs/model/bug.py	2011-02-21 02:55:12 +0000
@@ -1779,11 +1779,15 @@
     def _known_viewers(self):
         """A set of known persons able to view this bug.
 
-        Seed it by including the list of all owners of pillars for bugtasks
-        for the bug.
+        This method must return an empty set or bug searches will trigger late
+        evaluation. Any 'should be set on load' propertis must be done by the
+        bug search.
+
+        If you are tempted to change this method, don't. Instead see
+        userCanView which defines the just-in-time policy for bug visibility,
+        and BugTask._search which honours visibility rules.
         """
-        pillar_owners = [bt.pillar.owner.id for bt in self.bugtasks]
-        return set(pillar_owners)
+        return set()
 
     def userCanView(self, user):
         """See `IBug`.
@@ -1819,6 +1823,12 @@
                 if user.inTeam(subscription.person):
                     self._known_viewers.add(user.id)
                     return True
+            # Pillar owners can view it. Note that this is contentious and
+            # possibly incorrect: see bug 702429.
+            for pillar_owner in [bt.pillar.owner for bt in self.bugtasks]:
+                if user.inTeam(pillar_owner):
+                    self._known_viewers.add(user.id)
+                    return True
         return False
 
     def linkHWSubmission(self, submission):