Code review comment for lp:~lifeless/launchpad/bug-607935

Revision history for this message
Stuart Bishop (stub) wrote :

Mainly fine.

 - Remove the commented out eager bugwatch loader if it isn't needed.
 - Add a comment in build_comments_from_chunks() explaining that bugwatches will have been preloaded at this point so the code is not retrieving them one at a time from the db.
 - I see no tests for getMessagesForView's new slice behavior, in particular checking for off-by-one errors.

review: Approve

« Back to merge proposal