Merge lp:~lifeless/bzrtools/setup into lp:bzrtools

Proposed by Robert Collins
Status: Merged
Merged at revision: 765
Proposed branch: lp:~lifeless/bzrtools/setup
Merge into: lp:bzrtools
Diff against target: 26 lines (+10/-9)
1 file modified
setup.py (+10/-9)
To merge this branch: bzr merge lp:~lifeless/bzrtools/setup
Reviewer Review Type Date Requested Status
Aaron Bentley Disapprove
Review via email: mp+20339@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Robert Collins (lifeless) wrote :

Guard setup.py from executing setup unless it was actually executed, not just imported.

This is useful for bzr-plugin-info ( see http://doc.bazaar.canonical.com/bzr.dev/developers/plugin-api.html#plugin-metadata-before-installation).

Revision history for this message
Robert Collins (lifeless) wrote :

I was in a movie an hour ago - I'm not sure whats going on here.

Revision history for this message
Tim Penhey (thumper) wrote :

lp:~lifeless/bzrtools/setup has not been pushed to, so the old job runner would never have run the original job. Now the diff timed out (you should have an email for that too), and the creation email sent.

Revision history for this message
Aaron Bentley (abentley) wrote :

I categorically refuse to merge empty branches!

review: Disapprove
Revision history for this message
Robert Collins (lifeless) wrote :

Try now, sorry!

Revision history for this message
Robert Collins (lifeless) wrote :

Ping (I am patch piloting this week and saw this is still neither in-or-out - lp has a proper diff for it now though).

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'setup.py'
2--- setup.py 2008-02-13 04:58:32 +0000
3+++ setup.py 2010-05-06 04:09:26 +0000
4@@ -1,12 +1,13 @@
5 #!/usr/bin/env python
6 from distutils.core import setup
7 import version
8-setup(name="BzrTools",
9- version=version.__version__,
10- description="Handy utilities for working with Bazaar (bzr).",
11- author="Aaron Bentley",
12- author_email="aaron@aaronbentley.com",
13- license = "GNU GPL v2",
14- url="http://bazaar-vcs.org/BzrTools",
15- packages=['bzrlib.plugins.bzrtools', 'bzrlib.plugins.bzrtools.tests'],
16- package_dir={'bzrlib.plugins.bzrtools': '.', })
17+if __name__ == '__main__':
18+ setup(name="BzrTools",
19+ version=version.__version__,
20+ description="Handy utilities for working with Bazaar (bzr).",
21+ author="Aaron Bentley",
22+ author_email="aaron@aaronbentley.com",
23+ license = "GNU GPL v2",
24+ url="http://bazaar-vcs.org/BzrTools",
25+ packages=['bzrlib.plugins.bzrtools', 'bzrlib.plugins.bzrtools.tests'],
26+ package_dir={'bzrlib.plugins.bzrtools': '.', })

Subscribers

People subscribed via source and target branches