Bazaar

Code review comment for lp:~lifeless/bzr/bug-558343-wrong-host-with-proxy

  1. bug-558343-wrong-host-with-proxy
  2. Merge into bzr.dev
Revision history for this message
Vincent Ladeuil (vila) wrote :

I found time to look at the code. There is already a huge list of missing tests under a FIXME there (including the one that is missing here).

And yes, the fix is right and urllib2 didn't have the bug because it didn't implement CONNECT anyway.

review: Approve

« Back to merge proposal