Merge lp:~lifanxi/calibre/SNBOutput into lp:calibre

Proposed by Li Fanxi
Status: Merged
Merged at revision: 10067
Proposed branch: lp:~lifanxi/calibre/SNBOutput
Merge into: lp:calibre
Diff against target: 42 lines (+3/-4)
2 files modified
src/calibre/devices/bambook/driver.py (+1/-1)
src/calibre/ebooks/snb/snbfile.py (+2/-3)
To merge this branch: bzr merge lp:~lifanxi/calibre/SNBOutput
Reviewer Review Type Date Requested Status
Kovid Goyal Pending
Review via email: mp+70347@code.launchpad.net

Description of the change

Would you please merge this tree to include the latest bug fixes?

The code change in snbfile.py is correct, the fileName member in FileStream object should not be processed by ascii_filename, because it must contain the "/" character.

Thanks.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/calibre/devices/bambook/driver.py'
2--- src/calibre/devices/bambook/driver.py 2011-02-28 13:59:35 +0000
3+++ src/calibre/devices/bambook/driver.py 2011-08-03 18:19:46 +0000
4@@ -59,7 +59,7 @@
5
6 def reset(self, key='-1', log_packets=False, report_progress=None,
7 detected_device=None) :
8- self.open()
9+ self.open(None)
10
11 def open(self, library_uuid):
12 # Make sure the Bambook library is ready
13
14=== modified file 'src/calibre/ebooks/snb/snbfile.py'
15--- src/calibre/ebooks/snb/snbfile.py 2011-07-11 16:45:11 +0000
16+++ src/calibre/ebooks/snb/snbfile.py 2011-08-03 18:19:46 +0000
17@@ -7,7 +7,6 @@
18 import sys, struct, zlib, bz2, os
19
20 from calibre import guess_type
21-from calibre.utils.filenames import ascii_filename
22
23 class FileStream:
24 def IsBinary(self):
25@@ -158,7 +157,7 @@
26 f.fileBody = open(os.path.join(tdir,fileName), 'rb').read()
27 f.fileName = fileName.replace(os.sep, '/')
28 if isinstance(f.fileName, unicode):
29- f.fileName = ascii_filename(f.fileName).encode('ascii')
30+ f.fileName = f.fileName.encode("ascii", "ignore");
31 self.files.append(f)
32
33 def AppendBinary(self, fileName, tdir):
34@@ -168,7 +167,7 @@
35 f.fileBody = open(os.path.join(tdir,fileName), 'rb').read()
36 f.fileName = fileName.replace(os.sep, '/')
37 if isinstance(f.fileName, unicode):
38- f.fileName = ascii_filename(f.fileName).encode('ascii')
39+ f.fileName = f.fileName.encode("ascii", "ignore");
40 self.files.append(f)
41
42 def GetFileStream(self, fileName):

Subscribers

People subscribed via source and target branches