Merge lp:~libqtelegram-team/telegram-app/reset-emblem-counter into lp:telegram-app/app-dev

Proposed by Michał Karnicki
Status: Merged
Approved by: Michał Karnicki
Approved revision: 206
Merged at revision: 220
Proposed branch: lp:~libqtelegram-team/telegram-app/reset-emblem-counter
Merge into: lp:telegram-app/app-dev
Diff against target: 23 lines (+2/-4)
1 file modified
telegram.qml (+2/-4)
To merge this branch: bzr merge lp:~libqtelegram-team/telegram-app/reset-emblem-counter
Reviewer Review Type Date Requested Status
libqtelegram team Pending
Review via email: mp+244497@code.launchpad.net

Description of the change

Something's still not working in the push client :/

To post a comment you must log in.
Revision history for this message
Michał Karnicki (karni) wrote :

what the heck :(

push - push client loaded
push - unhandled error: Did not receive a reply. Possible causes include: the remote application did not send a reply, the message bus security policy blocked the reply, the reply timeout expired, or the network connection was broken.
tg.plugin.logic: push notification error: "Unknown method"
push - can't register, empty token.
tg.plugin.logic: Got dialogs: 20
push - unhandled error: Did not receive a reply. Possible causes include: the remote application did not send a reply, the message bus security policy blocked the reply, the reply timeout expired, or the network connection was broken.
tg.plugin.logic: push notification error: "Did not receive a reply. Possible causes include: the remote application did not send a reply, the message bus security policy blocked the reply, the reply timeout expired, or the network connection was broken."
file:///opt/click.ubuntu.com/com.ubuntu.telegram/0.9.27.203/telegram.qml:752: TypeError: Cannot read property 'name' of undefined

Revision history for this message
Michał Karnicki (karni) wrote :

The push client has been fixed, I have tested that change and it works.

The only problem I see is a bug I will file today:

1. Open Telegram
2. Put it to background
3. Send youself a message
4. Touch the launcher or switch back to Telegram
5. You have to *TOUCH* the application for onActiveFocusChanged to be called, and this is when we zero the counter.

206. By Michał Karnicki

Merge dev branch.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'telegram.qml'
2--- telegram.qml 2015-01-26 02:23:50 +0000
3+++ telegram.qml 2015-01-26 04:05:26 +0000
4@@ -76,8 +76,7 @@
5 // We do this to register for push when U1 account was
6 // set-up after Telegram was run without it first.
7 pushClient.appId = root.appId;
8-// console.log("push - resetting emblem");
9-// pushClient.count = 0;
10+ pushClient.count = 0;
11 }
12 }
13 }
14@@ -467,8 +466,7 @@
15 onLoaded: {
16 pushClient.notificationsChanged.connect(telegramClient.onPushNotifications);
17 pushClient.error.connect(telegramClient.onPushError);
18-// console.log("push - resetting emblem");
19-// pushClient.count = 0;
20+ pushClient.count = 0;
21
22 if (!appSettings.contents.isLoggedIn) {
23 // This should never happen, as we start the Loader in onAuthLoggedIn.

Subscribers

People subscribed via source and target branches

to all changes: