Merge lp:~libqtelegram-team/telegram-app/bugfix-1348724 into lp:~libqtelegram-team/telegram-app/qml-plugin
Proposed by
Roberto Mier Escandon
Status: | Rejected |
---|---|
Rejected by: | Roberto Mier Escandon |
Proposed branch: | lp:~libqtelegram-team/telegram-app/bugfix-1348724 |
Merge into: | lp:~libqtelegram-team/telegram-app/qml-plugin |
Diff against target: |
102 lines (+25/-16) 4 files modified
qmlplugin/models/messagesmodel.cpp (+22/-5) qmlplugin/telegramclient.cpp (+1/-8) qmlplugin/telegramclient.h (+0/-1) uitest/uitest.qml (+2/-2) |
To merge this branch: | bzr merge lp:~libqtelegram-team/telegram-app/bugfix-1348724 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michał Karnicki (community) | Approve | ||
Review via email:
|
Description of the change
Received messages in a list are sorted from most to less recent and should be always added at the end or inserted at beginning. This change evaluates if needed to append or prepend them and does the operation.
This way is not needed to have a proxy for sorting messages because list will remain always sorted.
Anyway, this change must be considered "under observation" for every new operation involving the messages model because it could happen that is not always valid or should it be completed with any special case.
To post a comment you must log in.
Unmerged revisions
- 182. By Roberto Mier Escandon
-
BUGFIX for 1348724; dialog history messages not well sorted
inline comments, then +1