Merge lp:~libqtelegram-team/telegram-app/app-very-slow-great-lag-after-update-2.2.4 into lp:telegram-app

Proposed by Jin
Status: Merged
Approved by: Roberto Mier Escandon
Approved revision: 189
Merged at revision: 187
Proposed branch: lp:~libqtelegram-team/telegram-app/app-very-slow-great-lag-after-update-2.2.4
Merge into: lp:telegram-app
Diff against target: 234 lines (+36/-27)
6 files modified
telegram/app/qml/AccountContactsPage.qml (+3/-3)
telegram/app/qml/AccountDialogPage.qml (+10/-4)
telegram/app/qml/AccountListItem.qml (+1/-0)
telegram/app/qml/AccountPage.qml (+8/-9)
telegram/app/qml/ProfilePage.qml (+1/-1)
telegram/app/qml/telegram.qml (+13/-10)
To merge this branch: bzr merge lp:~libqtelegram-team/telegram-app/app-very-slow-great-lag-after-update-2.2.4
Reviewer Review Type Date Requested Status
Roberto Mier Escandon (community) Approve
Review via email: mp+294728@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Roberto Mier Escandon (rmescandon) wrote :

much better. Ship it!

review: Approve
Revision history for this message
Jin (jindallo) wrote :

Hello Roberto,

Thanks for your approval!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'telegram/app/qml/AccountContactsPage.qml'
2--- telegram/app/qml/AccountContactsPage.qml 2016-04-28 12:07:11 +0000
3+++ telegram/app/qml/AccountContactsPage.qml 2016-05-15 13:27:32 +0000
4@@ -128,7 +128,7 @@
5 text: i18n.tr("Back")
6 onTriggered: {
7 page.state = "default"
8- pageStack.clear();
9+ pageStack.removePages(page);
10 }
11 }
12 }
13@@ -265,7 +265,7 @@
14 // refreshSubtitle();
15 } else if (newSecretChatMode) {
16 telegramObject.messagesCreateEncryptedChat(model.id);
17- pageStack.clear();
18+ pageStack.removePages(page);
19 } else if (addToGroupMode) {
20 var dialog = PopupUtils.open(add_contact_to_group_chat_component);
21 dialog.setData(user.id, user.fullName, groupChatTitle);
22@@ -289,7 +289,7 @@
23 telegram.messagesCreateChat(list.list, groupChatTitle);
24 state = "default";
25 groupChatTitle = "";
26- pageStack.clear();
27+ pageStack.removePages(page);
28 }
29
30 function refreshSubtitle() {
31
32=== modified file 'telegram/app/qml/AccountDialogPage.qml'
33--- telegram/app/qml/AccountDialogPage.qml 2016-04-27 08:49:59 +0000
34+++ telegram/app/qml/AccountDialogPage.qml 2016-05-15 13:27:32 +0000
35@@ -60,7 +60,10 @@
36 iconName: "next"
37 text: i18n.tr("Forward")
38 visible: enchat == telegramObject.nullEncryptedChat
39- onTriggered: message_list.forwardSelected()
40+ onTriggered: {
41+ message_list.forwardSelected()
42+ pageStack.removePages(dialog_page)
43+ }
44 },
45 Action {
46 id: multiDeleteAction
47@@ -84,7 +87,7 @@
48 if (message_list.inSelectionMode) {
49 message_list.cancelSelection()
50 } else {
51- pageStack.removePages(pageStack.primaryPage);
52+ pageStack.removePages(dialog_page);
53 }
54 }
55 }
56@@ -218,8 +221,11 @@
57 telegramObject: dialog_page.telegramObject
58 currentDialog: dialog_page.currentDialog
59
60-// onFocusRequest: send_msg.setFocus()
61- onForwardRequest: dialog_page.forwardRequest(messageIds);
62+ //onFocusRequest: send_msg.setFocus()
63+ onForwardRequest: {
64+ dialog_page.forwardRequest(messageIds);
65+ pageStack.removePages(dialog_page);
66+ }
67 onDialogRequest: account_page.currentDialog = dialogObject
68 onTagSearchRequest: msg_box.tagSearchRequest(tag)
69 onReplyToRequest: send_msg.replyTo(msgId)
70
71=== modified file 'telegram/app/qml/AccountListItem.qml'
72--- telegram/app/qml/AccountListItem.qml 2016-04-08 06:26:31 +0000
73+++ telegram/app/qml/AccountListItem.qml 2016-05-15 13:27:32 +0000
74@@ -92,6 +92,7 @@
75 }
76 onAuthCodeRequested: {
77 console.log("authCodeRequested");
78+ pageStack.setPrimaryPage();
79 pageStack.addPageToCurrentColumn(pageStack.primaryPage, account_code_page_component, {
80 "phoneRegistered": telegram.authPhoneRegistered,
81 "timeOut": sendCallTimeout
82
83=== modified file 'telegram/app/qml/AccountPage.qml'
84--- telegram/app/qml/AccountPage.qml 2016-04-29 11:20:20 +0000
85+++ telegram/app/qml/AccountPage.qml 2016-05-15 13:27:32 +0000
86@@ -15,7 +15,6 @@
87 id: account_page
88
89 property int profileCount: 0
90- property var dialogPage;
91
92 property alias telegramObject: dialogs.telegramObject
93 property alias currentDialog: dialogs.currentDialog
94@@ -40,7 +39,7 @@
95 // acc_frame.activeRequest()
96 // Cutegram.active()
97
98- pageStack.addPageToNextColumn(pageStack.primaryPage, account_dialog_page, {
99+ pageStack.addPageToNextColumn(account_page, account_dialog_page, {
100 "telegramObject": telegramObject,
101 "currentDialog": currentDialog
102 });
103@@ -85,27 +84,27 @@
104 z: 10
105
106 onNewSecretChatClicked: {
107- pageStack.addPageToCurrentColumn(pageStack.primaryPage, contacts_page_component, {
108+ pageStack.addPageToCurrentColumn(account_page, contacts_page_component, {
109 "telegram": telegramObject,
110 "state": "new-secret-chat"
111 });
112 }
113
114 onNewGroupClicked: {
115- pageStack.addPageToCurrentColumn(pageStack.primaryPage, contacts_page_component, {
116+ pageStack.addPageToCurrentColumn(account_page, contacts_page_component, {
117 "telegram": telegramObject,
118 "state": "new-group-chat"
119 });
120 }
121
122 onContactsClicked: {
123- pageStack.addPageToCurrentColumn(pageStack.primaryPage, contacts_page_component, {
124+ pageStack.addPageToCurrentColumn(account_page, contacts_page_component, {
125 "telegram": telegramObject
126 });
127 }
128
129 onSettingsClicked: {
130- pageStack.addPageToNextColumn(pageStack.primaryPage, settings_page_component, {
131+ pageStack.addPageToNextColumn(account_page, settings_page_component, {
132 "telegram": telegramObject
133 });
134 }
135@@ -115,7 +114,7 @@
136 }
137
138 onAddAccountClicked: {
139- pageStack.addPageToCurrentColumn(pageStack.primaryPage, auth_countries_page_component);
140+ pageStack.addPageToCurrentColumn(account_page, auth_countries_page_component);
141 }
142
143 onAccountClicked: {
144@@ -176,7 +175,7 @@
145 onCurrentDialogChanged: {
146 if (currentDialog && currentDialog != telegramObject.nullDialog) {
147 pageStack.clear();
148- dialogPage = pageStack.addPageToNextColumn(pageStack.primaryPage, account_dialog_page, {"maxId": 0});
149+ pageStack.addPageToNextColumn(account_page, account_dialog_page, {"maxId": 0});
150
151 var tag = currentDialog.peer.chatId ? currentDialog.peer.chatId : currentDialog.peer.userId;
152 pushClient.clearPersistent([tag]);
153@@ -247,7 +246,7 @@
154 }
155
156 onAddContactManually: {
157- pageStack.addPageToNextColumn(pageStack.primaryPage, add_contact_page_component, {
158+ pageStack.addPageToNextColumn(account_page, add_contact_page_component, {
159 "telegram": telegramObject,
160 "addManually": true
161 });
162
163=== modified file 'telegram/app/qml/ProfilePage.qml'
164--- telegram/app/qml/ProfilePage.qml 2016-04-08 06:08:04 +0000
165+++ telegram/app/qml/ProfilePage.qml 2016-05-15 13:27:32 +0000
166@@ -113,7 +113,7 @@
167 }
168
169 function addMember() {
170- pageStack.addPageToNextColumn(pageStack.primaryPage, contacts_page_component, {
171+ pageStack.addPageToNextColumn(profile_page, contacts_page_component, {
172 telegram: telegram,
173 state: "add-to-group",
174 groupChatId: dialogId,
175
176=== modified file 'telegram/app/qml/telegram.qml'
177--- telegram/app/qml/telegram.qml 2016-04-29 10:33:09 +0000
178+++ telegram/app/qml/telegram.qml 2016-05-15 13:27:32 +0000
179@@ -90,7 +90,7 @@
180 function showIntro() {
181 pageStack.forceSinglePage = (profiles.count == 0);
182 if (profiles.count == 0) {
183- pageStack.primaryPageSource = intro_page_component;
184+ pageStack.primaryPage = introPage;
185 }
186 }
187
188@@ -233,6 +233,7 @@
189
190 property bool forceSinglePage: false
191
192+ asynchronous: false
193 anchors.fill: parent
194 layouts: [
195 PageColumnsLayout {
196@@ -257,18 +258,19 @@
197 }
198 ]
199
200+ function setPrimaryPage() {
201+ pageStack.primaryPage = introPage;
202+ }
203+
204 function clear() {
205 pageStack.removePages(pageStack.primaryPage);
206 }
207
208- Component {
209- id: intro_page_component
210-
211- IntroPage {
212- onStartMessaging: {
213- pageStack.forceSinglePage = false;
214- pageStack.addPageToCurrentColumn(pageStack.primaryPage, auth_countries_page_component);
215- }
216+ IntroPage {
217+ id: introPage
218+ onStartMessaging: {
219+ pageStack.forceSinglePage = false;
220+ pageStack.addPageToCurrentColumn(introPage, auth_countries_page_component);
221 }
222 }
223
224@@ -276,8 +278,9 @@
225 id: auth_countries_page_component
226
227 AuthCountriesPage {
228+ id: authCountriesPage
229 onCountryEntered: {
230- pageStack.addPageToNextColumn(pageStack.primaryPage, auth_number_page_component, {
231+ pageStack.addPageToNextColumn(authCountriesPage, auth_number_page_component, {
232 "countryCode": code
233 });
234 }

Subscribers

People subscribed via source and target branches

to all changes:
to status/vote changes: