Merge lp:~libqtelegram-team/telegram-app/app-dev-fix-profile-image into lp:telegram-app/app-dev

Proposed by Michał Karnicki
Status: Merged
Approved by: Roberto Mier Escandon
Approved revision: 204
Merged at revision: 204
Proposed branch: lp:~libqtelegram-team/telegram-app/app-dev-fix-profile-image
Merge into: lp:telegram-app/app-dev
Diff against target: 27 lines (+4/-2)
1 file modified
ui/GroupProfilePage.qml (+4/-2)
To merge this branch: bzr merge lp:~libqtelegram-team/telegram-app/app-dev-fix-profile-image
Reviewer Review Type Date Requested Status
libqtelegram team Pending
Review via email: mp+244561@code.launchpad.net

Description of the change

Works with this plugin branch:
lp:~libqtelegram-team/libqtelegram/same-image-all-chats-fix

Tested by:
 - opening a couple different group profiles
 - tapping on their photo
 - tapping on generic image in the group profile -- as expected, nothing happens

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ui/GroupProfilePage.qml'
2--- ui/GroupProfilePage.qml 2014-12-11 18:50:22 +0000
3+++ ui/GroupProfilePage.qml 2014-12-12 11:13:41 +0000
4@@ -57,7 +57,6 @@
5 body: Item {
6 anchors.fill: parent
7
8-
9 Image {
10 id: photoImage
11 anchors {
12@@ -70,11 +69,14 @@
13 height: width
14 asynchronous: true
15 fillMode: Image.PreserveAspectCrop
16- source: groupModel.photo
17+ source: groupModel.photo !== "" ? groupModel.photo
18+ : "../images/" + Avatar.getAvatar(groupModel.chatId, true)
19
20 MouseArea {
21 anchors.fill: parent
22 onClicked: {
23+ if (groupModel.photo === "") return;
24+
25 var properties = { "title": groupModel.title,
26 "photoPreviewSource": groupModel.photo };
27 pageStack.push(previewPage, properties);

Subscribers

People subscribed via source and target branches

to all changes: