Merge lp:~libqtelegram-team/telegram-app/app-dev-enlarge-swipe-action-touch-area into lp:telegram-app/app-dev

Proposed by Michał Karnicki
Status: Merged
Approved by: Riccardo Padovani
Approved revision: 322
Merged at revision: 323
Proposed branch: lp:~libqtelegram-team/telegram-app/app-dev-enlarge-swipe-action-touch-area
Merge into: lp:telegram-app/app-dev
Diff against target: 45 lines (+6/-6)
1 file modified
components/listitems/ListItemWithActions.qml (+6/-6)
To merge this branch: bzr merge lp:~libqtelegram-team/telegram-app/app-dev-enlarge-swipe-action-touch-area
Reviewer Review Type Date Requested Status
Roberto Mier Escandon (community) Approve
Riccardo Padovani Approve
Review via email: mp+257518@code.launchpad.net

Description of the change

Enlarge touch area of icons in swipe areas. Tested by clicking around the icons to ensure touch area is larger than it was before.

To post a comment you must log in.
Revision history for this message
Riccardo Padovani (rpadovani) wrote :

lgtm

review: Approve
Revision history for this message
Roberto Mier Escandon (rmescandon) wrote :

lgtm though not tested

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'components/listitems/ListItemWithActions.qml'
2--- components/listitems/ListItemWithActions.qml 2015-02-23 15:00:09 +0000
3+++ components/listitems/ListItemWithActions.qml 2015-04-27 12:50:31 +0000
4@@ -227,9 +227,9 @@
5 top: parent.top
6 bottom: parent.bottom
7 right: parent.right
8- rightMargin: units.gu(2)
9+ rightMargin: units.gu(1)
10 }
11- spacing: units.gu(2)
12+ spacing: 0
13 Repeater {
14 id: leftActionsRepeater
15
16@@ -238,7 +238,7 @@
17 property alias image: img
18
19 height: leftActionView.height
20- width: root.actionWidth
21+ width: root.actionWidth + units.gu(2)
22
23 Icon {
24 id: img
25@@ -270,9 +270,9 @@
26 top: parent.top
27 bottom: parent.bottom
28 left: parent.left
29- leftMargin: units.gu(2)
30+ leftMargin: units.gu(1)
31 }
32- spacing: units.gu(2)
33+ spacing: 0
34 Repeater {
35 id: rightActionsRepeater
36
37@@ -281,7 +281,7 @@
38 property alias image: img
39
40 height: rightActionsView.height
41- width: root.actionWidth
42+ width: root.actionWidth + units.gu(2)
43
44 Icon {
45 id: img

Subscribers

People subscribed via source and target branches

to all changes: