Merge lp:~libqtelegram-team/telegram-app/app-dev-cpp-push-helper into lp:telegram-app/app-dev
Proposed by
Michał Karnicki
Status: | Merged | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Approved by: | Giulio Collura | ||||||||||||
Approved revision: | 278 | ||||||||||||
Merged at revision: | 269 | ||||||||||||
Proposed branch: | lp:~libqtelegram-team/telegram-app/app-dev-cpp-push-helper | ||||||||||||
Merge into: | lp:telegram-app/app-dev | ||||||||||||
Diff against target: |
700 lines (+594/-11) 12 files modified
.bzrignore (+1/-0) CMakeLists.txt (+38/-1) config.h.in (+0/-1) push.cpp (+25/-0) push.json (+1/-1) pushclient.cpp (+113/-0) pushclient.h (+76/-0) pushhelper.cpp (+290/-0) pushhelper.h (+41/-0) scripts/pushlog.sh (+3/-0) src.moved/_sctelegram.ini (+0/-8) telegram.qml (+6/-0) |
||||||||||||
To merge this branch: | bzr merge lp:~libqtelegram-team/telegram-app/app-dev-cpp-push-helper | ||||||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Giulio Collura | Approve | ||
Roberto Mier Escandon (community) | Needs Fixing | ||
Review via email:
|
Description of the change
Rewrote push helper in C++.
Add 'grouping' of notifications (no counter in notification of grouped messages yet).
Add clearing counter / notifications when logging out.
Requires lib: lp:~libqtelegram-team/libqtelegram/dev-cpp-push-helper
https:/
Tested:
- reading msg on PC and opening Tg clears counter/
- opening Tg and reading msg on PC clears counter/
- opening chat clears counter
- most of incoming push notification types listed in pushhelper.cpp
To post a comment you must log in.
Roberto, any idea why I need to use line 101 instead of 97 (which doesn't work)?