Merge ~liaou3/checkbox-limerick/+git/checkbox-provider-limerick:add_usb_wake_from_keyboard into ~checkbox-dev/checkbox-limerick/+git/checkbox-provider-limerick:master

Proposed by Vincent Liao
Status: Merged
Approved by: Vincent Liao
Approved revision: dd5fa5584674a7eb2b1a3b8a541e73958308597a
Merged at revision: 749424a987f91f8afe0f7b97e0b9ed36b0613386
Proposed branch: ~liaou3/checkbox-limerick/+git/checkbox-provider-limerick:add_usb_wake_from_keyboard
Merge into: ~checkbox-dev/checkbox-limerick/+git/checkbox-provider-limerick:master
Diff against target: 72 lines (+32/-0)
5 files modified
units/kr260-test-plan-classic.pxu (+1/-0)
units/kv260-test-plan-classic.pxu (+1/-0)
units/usb/category.pxu (+3/-0)
units/usb/jobs.pxu (+21/-0)
units/usb/test-plan.pxu (+6/-0)
Reviewer Review Type Date Requested Status
StanleyHuang Approve
PeiYao Chang Approve
Rick Wu Pending
Vic Liu Pending
Weichen Wu Pending
Review via email: mp+463099@code.launchpad.net

Commit message

Add wake from usb keyboard tests

Description of the change

To cover this LP#2057466, we add test to cover wake from usb keyboard.

Submission: https://certification.canonical.com/hardware/202202-29984/submission/361959/

To post a comment you must log in.
Revision history for this message
PeiYao Chang (baconyao) wrote :

See my inline comment

review: Needs Information
Revision history for this message
PeiYao Chang (baconyao) wrote :

+1

review: Approve
Revision history for this message
StanleyHuang (stanley31) :
review: Needs Information
Revision history for this message
Vincent Liao (liaou3) wrote :

Answered

Revision history for this message
StanleyHuang (stanley31) wrote :

Thanks for the answer, LGTM.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/kr260-test-plan-classic.pxu b/units/kr260-test-plan-classic.pxu
2index f6e21d2..548e239 100644
3--- a/units/kr260-test-plan-classic.pxu
4+++ b/units/kr260-test-plan-classic.pxu
5@@ -32,6 +32,7 @@ nested_part:
6 com.canonical.certification::client-cert-iot-server-22-04-manual
7 limerick-after-suspend-monitor-manual
8 com.canonical.certification::after-suspend-graphics-integrated-gpu-cert-manual
9+ limerick-usb-manual
10 exclude:
11 com.canonical.certification::audio.* # keep if audio is not supported
12 com.canonical.certification::bluetooth.* # keep if bluetooth is not supported
13diff --git a/units/kv260-test-plan-classic.pxu b/units/kv260-test-plan-classic.pxu
14index b343bf9..cf58bba 100644
15--- a/units/kv260-test-plan-classic.pxu
16+++ b/units/kv260-test-plan-classic.pxu
17@@ -42,6 +42,7 @@ nested_part:
18 com.canonical.certification::client-cert-iot-server-22-04-manual
19 limerick-after-suspend-monitor-manual
20 com.canonical.certification::after-suspend-graphics-integrated-gpu-cert-manual
21+ limerick-usb-manual
22 exclude:
23 com.canonical.certification::audio.* # keep if audio is not supported
24 com.canonical.certification::bluetooth.* # keep if bluetooth is not supported
25diff --git a/units/usb/category.pxu b/units/usb/category.pxu
26new file mode 100644
27index 0000000..b92a601
28--- /dev/null
29+++ b/units/usb/category.pxu
30@@ -0,0 +1,3 @@
31+unit: category
32+id: limerick-usb
33+_name: Limerick USB Test
34diff --git a/units/usb/jobs.pxu b/units/usb/jobs.pxu
35new file mode 100644
36index 0000000..32dde2b
37--- /dev/null
38+++ b/units/usb/jobs.pxu
39@@ -0,0 +1,21 @@
40+unit: job
41+plugin: user-interact-verify
42+id: limerick-usb/wake-on-usb-keyboard
43+category_id: limerick-usb
44+user: root
45+estimated_duration: 1m
46+_summary: Wake system up from suspend with usb keyboard
47+command:
48+ wakeup_sources=$(find /sys/ | grep /power/wakeup\$ | grep usb)
49+ for device in $wakeup_sources; do
50+ echo enabled > "$device"
51+ done
52+ systemctl suspend
53+_purpose:
54+ To test if the system could wake up from suspend with usb keyboard
55+_steps:
56+ 1. Press enter to enter suspend.
57+ 2. Wait for 10 seconds.
58+ 3. Press 'Enter' to wake system up.
59+_verification:
60+ Does the system resume from suspend successfully?
61diff --git a/units/usb/test-plan.pxu b/units/usb/test-plan.pxu
62new file mode 100644
63index 0000000..e39a00b
64--- /dev/null
65+++ b/units/usb/test-plan.pxu
66@@ -0,0 +1,6 @@
67+id: limerick-usb-manual
68+unit: test plan
69+_name: Limerick Manual USB Tests
70+_description: Manual USB test for Limerick
71+include:
72+ limerick-usb/wake-on-usb-keyboard

Subscribers

People subscribed via source and target branches