Merge ~liaou3/checkbox-iiotg/+git/checkbox-provider-intliotg:absolute_path_for_tsn-listener into ~checkbox-dev/checkbox-iiotg/+git/checkbox-provider-intliotg:master

[Vincent Liao]

Modify: Provide the absolute path for tsn server to run tsn-listener

Since tsn server need to run the command tsn-listener, with snap `checkbox-iiotg-classic` installed, we could run it under the path /snap/checkbox-iiotg-classic/current/usr/bin/ which is inside of snap `checkbox-iiotg`.

The `tsn-talker` is inside of `checkbox-iiotg`, so we should provide the absolute path to it

submission: https://certification.canonical.com/hardware/202306-31658/submission/343427/test/203648/result/37679331/

Changed: `./tsn-listener` -> `/snap/checkbox-iiotg-classic/current/usr/bin/tsn-listener`

[Patrick Liu (patliu)]

LGTM

review: Approve

[StanleyHuang (stanley31)]

I am a bit confuse about the description, is the tsa-listener binary file inside of checkbox-iiotg snap or checkbox-iiotg-classic snap?

"""
we could run it under the path /snap/checkbox-iiotg-classic/current/usr/bin/ which is inside of snap `checkbox-iiotg`."""

review: Needs Information

[Vic Liu (zongminl)]

What happens when you're running this test in a Ubuntu Core image? That would probably cause a problem when you're using hard-coded path /snap/checkbox-iiotg-classic/

review: Needs Fixing

[Vincent Liao (liaou3)]

> What happens when you're running this test in a Ubuntu Core image? That would
> probably cause a problem when you're using hard-coded path /snap/checkbox-
> iiotg-classic/

The machine need to run this command is the tsn server which is a machine that we could control. And also we assume the tsn server should be installed with ubuntu classic image. That's why this path is hardcoded with `classic`.

[Vic Liu (zongminl)]

Maybe $SNAP env can be a better option?

[Vincent Liao (liaou3)]

> Maybe $SNAP env can be a better option?

No, we can't. Because things will go wrong when testing on core image.

We are trying to run "$SNAP/usr/bin/tsn-listener", then it will be "/snap/checkbox-iiotg/current/usr/bin/tsn-listener" running on the tsn server which is installed with classic image.

[Vic Liu (zongminl)]

+1, thank you

review: Approve

diff --git a/bin/tsn_credit_based_shaper.sh b/bin/tsn_credit_based_shaper.sh
index f023b3b..6635815 100755
--- a/bin/tsn_credit_based_shaper.sh
+++ b/bin/tsn_credit_based_shaper.sh
@@ -31,7 +31,7 @@ echo ""
 
 echo "## Start listening on TSN server..."
 output=$(mktemp)
-(sshpass -p "$server_pwd" ssh -o StrictHostKeyChecking=no "$server_user"@"$server_ip" "echo $server_pwd | sudo -S stdbuf -oL timeout 55 ./tsn-listener -d 01:AA:AA:AA:AA:AA -i $server_eth_interface -s 1500") | tee "$output"
+(sshpass -p "$server_pwd" ssh -o StrictHostKeyChecking=no "$server_user"@"$server_ip" "echo $server_pwd | sudo -S stdbuf -oL timeout 55 /snap/checkbox-iiotg-classic/current/usr/bin/tsn-listener -d 01:AA:AA:AA:AA:AA -i $server_eth_interface -s 1500") | tee "$output"
 lines=$(tail -n 50 "$output")
 while read -r line
 do