Merge ~liaou3/checkbox-iiotg/+git/checkbox-provider-intliotg:modify_pass_criteria into ~checkbox-dev/checkbox-iiotg/+git/checkbox-provider-intliotg:master

Proposed by Vincent Liao
Status: Merged
Approved by: Vincent Liao
Approved revision: 13617cebfe6bcae63fce39d71eb46c4d3bdd90ae
Merged at revision: acf3454ee891b7955578ae32b1ee48b91bc921cf
Proposed branch: ~liaou3/checkbox-iiotg/+git/checkbox-provider-intliotg:modify_pass_criteria
Merge into: ~checkbox-dev/checkbox-iiotg/+git/checkbox-provider-intliotg:master
Diff against target: 36 lines (+6/-6)
1 file modified
units/tsn/jobs.pxu (+6/-6)
Reviewer Review Type Date Requested Status
PeiYao Chang Approve
Vic Liu Approve
Patrick Liu Pending
StanleyHuang Pending
Rick Wu Pending
Review via email: mp+455846@code.launchpad.net

Commit message

Fix: Set default pass criteria from 200 ns to 100 ns for time sync test

According to the page 27 in the tsn document [1] provided by intel, the pass criteria should be 100ns instead of 200ns.

[1] https://drive.google.com/file/d/1HsksCfLoUTz_baZU98omYuGBq-LDZKGe/view?usp=drive_link

Description of the change

If the testing environment is two machines connect to each other directly, the pass criteria for time sync test should be under 100 ns.

To post a comment you must log in.
Revision history for this message
Vic Liu (zongminl) wrote (last edit ):

Can you please share with us the rationale of this change? Any reference document?
If possible, can you please put that in the commit message

review: Needs Information
Revision history for this message
Vincent Liao (liaou3) wrote :

> Can you please share with us the rationale of this change? Any reference
> document?
> If possible, can you please put that in the commit message

@Vic, the pass criteria is always 100ns in page 27 in this tsn document [1] provided by intel. I accidentally type the wrong value while doing the job automation in previous commits. But don't worry, the pass criteria for previous tsn tests were 100ns.

[1] https://drive.google.com/file/d/1HsksCfLoUTz_baZU98omYuGBq-LDZKGe/view?usp=drive_link

Revision history for this message
Vic Liu (zongminl) wrote (last edit ):

All good, thank you, but please add that rationale to your commit message

review: Approve
Revision history for this message
PeiYao Chang (baconyao) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/tsn/jobs.pxu b/units/tsn/jobs.pxu
2index 719da83..c7b5416 100644
3--- a/units/tsn/jobs.pxu
4+++ b/units/tsn/jobs.pxu
5@@ -172,12 +172,12 @@ command:
6 while read -r line
7 do
8 offset=$(echo "$line" | grep -o 'master offset\s*-\?[0-9]\+ s' | awk '{print $3}')
9- if [ "$offset" -gt "${TSN_MAX_MASTER_OFFSET:-200}" ] || [ "$offset" -lt -"${TSN_MAX_MASTER_OFFSET:-200}" ]; then
10- echo "FAIL: master offset is not within -"${TSN_MAX_MASTER_OFFSET:-200}" to "${TSN_MAX_MASTER_OFFSET:-200}" for the last 10 seconds."
11+ if [ "$offset" -gt "${TSN_MAX_MASTER_OFFSET:-100}" ] || [ "$offset" -lt -"${TSN_MAX_MASTER_OFFSET:-100}" ]; then
12+ echo "FAIL: master offset is not within -"${TSN_MAX_MASTER_OFFSET:-100}" to "${TSN_MAX_MASTER_OFFSET:-100}" for the last 10 seconds."
13 exit 1
14 fi
15 done <<< "$lines"
16- echo "PASS: master offset is within -"${TSN_MAX_MASTER_OFFSET:-200}" to "${TSN_MAX_MASTER_OFFSET:-200}" for the last 10 seconds."
17+ echo "PASS: master offset is within -"${TSN_MAX_MASTER_OFFSET:-100}" to "${TSN_MAX_MASTER_OFFSET:-100}" for the last 10 seconds."
18
19 unit: template
20 template-resource: tsn/tsn-devices
21@@ -209,12 +209,12 @@ command:
22 while read -r line
23 do
24 offset=$(echo "$line" | grep -o 'master offset\s*-\?[0-9]\+ s' | awk '{print $3}')
25- if [ "$offset" -gt "${TSN_MAX_MASTER_OFFSET:-200}" ] || [ "$offset" -lt -"${TSN_MAX_MASTER_OFFSET:-200}" ]; then
26- echo "FAIL: master offset is not within -"${TSN_MAX_MASTER_OFFSET:-200}" to "${TSN_MAX_MASTER_OFFSET:-200}" for the last 10 seconds."
27+ if [ "$offset" -gt "${TSN_MAX_MASTER_OFFSET:-100}" ] || [ "$offset" -lt -"${TSN_MAX_MASTER_OFFSET:-100}" ]; then
28+ echo "FAIL: master offset is not within -"${TSN_MAX_MASTER_OFFSET:-100}" to "${TSN_MAX_MASTER_OFFSET:-100}" for the last 10 seconds."
29 exit 1
30 fi
31 done <<< "$lines"
32- echo "PASS: master offset is within -"${TSN_MAX_MASTER_OFFSET:-200}" to "${TSN_MAX_MASTER_OFFSET:-200}" for the last 10 seconds."
33+ echo "PASS: master offset is within -"${TSN_MAX_MASTER_OFFSET:-100}" to "${TSN_MAX_MASTER_OFFSET:-100}" for the last 10 seconds."
34
35 unit: template
36 template-resource: tsn/tsn-devices

Subscribers

People subscribed via source and target branches