Checkbox IIoTG

Merge ~liaou3/checkbox-iiotg/+git/checkbox-provider-intliotg:add_require_for_ptp-node-detect into ~checkbox-dev/checkbox-iiotg/+git/checkbox-provider-intliotg:master

  1. Git
  2. lp:~liaou3/checkbox-iiotg/+git/checkbox-provider-intliotg
  3. add_require_for_ptp-node-detect
  4. Merge into master
Proposed by Vincent Liao
Status: Merged
Approved by: Vincent Liao
Approved revision: 919bb71e89ed46cf9803b3e263c7d96d0e017774
Merged at revision: 8ba216cad459496bb710aca8700df3f4355b673b
Proposed branch: ~liaou3/checkbox-iiotg/+git/checkbox-provider-intliotg:add_require_for_ptp-node-detect
Merge into: ~checkbox-dev/checkbox-iiotg/+git/checkbox-provider-intliotg:master
Diff against target: 14 lines (+3/-0)
1 file modified
units/tgpio/jobs.pxu (+3/-0)
Reviewer Review Type Date Requested Status
StanleyHuang Approve
Patrick Liu (community) Approve
Rick Wu Pending
PeiYao Chang Pending
Vic Liu Pending
Review via email: mp+452640@code.launchpad.net

Commit message

Add require for ptp-virtual-device-node-detect prevent from running it when there's no tgpio supported

To post a comment you must log in.
Revision history for this message
Patrick Liu (patliu) wrote :

+1

review: Approve
Revision history for this message
StanleyHuang (stanley31) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/tgpio/jobs.pxu b/units/tgpio/jobs.pxu
2index af31df3..b14a5c5 100644
3--- a/units/tgpio/jobs.pxu
4+++ b/units/tgpio/jobs.pxu
5@@ -2,6 +2,9 @@ unit: job
6 category_id: tgpio
7 id: tgpio/ptp-virtual-device-node-detect
8 plugin: shell
9+imports: from com.canonical.plainbox import manifest
10+requires:
11+ manifest.has_tgpio == 'True'
12 _summary: Check if there's at least one virtual ptp device node
13 _description:
14 This test is to check if there's at least one virtual ptp device node

Subscribers

People subscribed via source and target branches